From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZEvty-0006GY-2x
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 04:49:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZEvts-00043N-Sl
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 04:49:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53730)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZEvts-000437-NG
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 04:49:16 -0400
Date: Tue, 14 Jul 2015 11:49:11 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150714114855-mutt-send-email-mst@redhat.com>
References: <1436247191-13577-1-git-send-email-tiejun.chen@intel.com>
	<1436247191-13577-9-git-send-email-tiejun.chen@intel.com>
	<alpine.DEB.2.02.1507131711200.17378@kaball.uk.xensource.com>
	<20150713200122-mutt-send-email-mst@redhat.com>
	<55A4CB84.90404@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55A4CB84.90404@intel.com>
Subject: Re: [Qemu-devel] [v9][PATCH 08/10] xen,
	gfx passthrough: register a isa bridge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On Tue, Jul 14, 2015 at 04:42:44PM +0800, Chen, Tiejun wrote:
> >>>diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
> >>>index 4356af4..703148e 100644
> >>>--- a/include/hw/xen/xen.h
> >>>+++ b/include/hw/xen/xen.h
> >>>@@ -51,4 +51,5 @@ void xen_register_framebuffer(struct MemoryRegion *mr);
> >>>  #  define HVM_MAX_VCPUS 32
> >>>  #endif
> >>>
> >>>+extern void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id);
> >>>  #endif /* QEMU_HW_XEN_H */
> >>
> >>You are right that I was confused on my previous comment, but it is true
> >>that it shouldn't be part of this patch: it should be part of patch
> 
> Right.
> 
> >>7/10. Also the declaration should probably not be in the xen.h header.
> >>
> >>Michael, where do you think should go?
> >
> >Donnu - add a header?
> >
> 
> What about the include/hw/i386/pc.h file?
> 
> Thanks
> Tiejun

Somewhat ugly, but OK I guess.