Re: [Qemu-devel] [Qemu-block] [PATCH 0/4] rbd cleanup and settings precedence fixes

[Kevin Wolf <kwolf@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]

Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben:
> On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote:
> > Ping
> > 
> > On 06/10/2015 08:28 PM, Josh Durgin wrote:
> > >Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of
> > >cache options and ceph settings. The cache option precedence in
> > >particular is important due to the potential for misconfigurations
> > >(ceph.conf setting rbd_cache=true, qemu setting cache=none) to
> > >accidentally put data at risk.
> > >
> > >Josh Durgin (4):
> > >   rbd: remove unused constants and fields
> > >   MAINTAINERS: update email address
> > >   rbd: make qemu's cache setting override any ceph setting
> > >   rbd: fix ceph settings precedence
> > >
> > >  MAINTAINERS |  2 +-
> > >  block/rbd.c | 64 +++++++++++++++++++++++++++++++++----------------------------
> > >  2 files changed, 36 insertions(+), 30 deletions(-)
> 
> This should go via Jeff:
> 
>   $ scripts/get_maintainer.pl -f block/rbd.c
>   Josh Durgin <josh.durgin@inktank.com> (supporter:RBD)
>   Jeff Cody <jcody@redhat.com> (supporter:RBD)
>   Kevin Wolf <kwolf@redhat.com> (supporter:Block layer core)
>   qemu-block@nongnu.org (open list:RBD)
> 
> Jeff is currently on vacation but will be back before the QEMU 2.4-rc1
> tag is made.

Considering that Josh is the primary maintainer for rbd and Jeff is just
merging patches for him, and that Jeff has already given R-b for patches
1 to 3, and that Jeff doesn't seem to be back yet, and that the patches
look good to me, I'm taking this through my tree for -rc1.

(I guess this is my longest "thanks, applied" sentence so far...)

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]