From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF14Y-00056q-Iu for qemu-devel@nongnu.org; Tue, 14 Jul 2015 10:20:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZF14X-0007J7-6i for qemu-devel@nongnu.org; Tue, 14 Jul 2015 10:20:38 -0400 Date: Tue, 14 Jul 2015 16:20:27 +0200 From: Kevin Wolf Message-ID: <20150714142027.GA4219@noname.redhat.com> References: <1433993326-26294-1-git-send-email-jdurgin@redhat.com> <5592DFC2.9060707@redhat.com> <20150709095920.GA28530@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: <20150709095920.GA28530@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/4] rbd cleanup and settings precedence fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Josh Durgin , qemu-devel@nongnu.org, qemu-block@nongnu.org, Jeff Cody --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben: > On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote: > > Ping > >=20 > > On 06/10/2015 08:28 PM, Josh Durgin wrote: > > >Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of > > >cache options and ceph settings. The cache option precedence in > > >particular is important due to the potential for misconfigurations > > >(ceph.conf setting rbd_cache=3Dtrue, qemu setting cache=3Dnone) to > > >accidentally put data at risk. > > > > > >Josh Durgin (4): > > > rbd: remove unused constants and fields > > > MAINTAINERS: update email address > > > rbd: make qemu's cache setting override any ceph setting > > > rbd: fix ceph settings precedence > > > > > > MAINTAINERS | 2 +- > > > block/rbd.c | 64 +++++++++++++++++++++++++++++++++------------------= ---------- > > > 2 files changed, 36 insertions(+), 30 deletions(-) >=20 > This should go via Jeff: >=20 > $ scripts/get_maintainer.pl -f block/rbd.c > Josh Durgin (supporter:RBD) > Jeff Cody (supporter:RBD) > Kevin Wolf (supporter:Block layer core) > qemu-block@nongnu.org (open list:RBD) >=20 > Jeff is currently on vacation but will be back before the QEMU 2.4-rc1 > tag is made. Considering that Josh is the primary maintainer for rbd and Jeff is just merging patches for him, and that Jeff has already given R-b for patches 1 to 3, and that Jeff doesn't seem to be back yet, and that the patches look good to me, I'm taking this through my tree for -rc1. (I guess this is my longest "thanks, applied" sentence so far...) Kevin --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJVpRqrAAoJEH8JsnLIjy/W6lEQAMZqfb6vhuPEBIFVe4a/HtZw 9Y/0+YIYE9LJmHy38S+MKFYaevgxzlYtxxdzYaXZwXgiuGWTP4DO2Mt49ZyolWRp PiXxjwY/RC6zQ/x3rPeBCdXhgQq5OKMCW+u5CiU9T2Fd7s4+ZR8wrGlHiWBWyMmQ sv1sIucboHcvxYxEfxRcHGPLwC9rHq1RulsaM3nm7gIaWpQwerc+kmP8edm0b7eb xIlcadWsh1aGIEPyMy8QFnm9eB5ro0HRVaphCh9QBZdjLDw47mrznmFbmU6M12r6 iGAqsOGFszUAT+LP/6M2HmUP7MFfvmDuBAmn9Z2t0tinEjRTDxxFtT/G57/2tnnm RHBl1ggZwfsamYKvgIAsh0Q9kJV9mxPtKbqiT6sVKPVvuy64RaADmp33QeeJF8dg D0La0WdQRYqChZcCdZg9xazOkUoUtXovWI1KAEIB18j9fbDb3QG3YdL02Ui47gtM lANXfmqvrQMShOi96UYtGMYZe9e8Pkn5m14fL7s5Pvg89orvCeKSbaqpFChWfKIE xeGj1S2iP9rnTecr5Kmwnrb+eywZHaPKIb4cXEz1i423cAyRa78J/7jvHHjzxN+/ 3SMD5r6XVJCPuZx+Uu0Zug0bds9OoMQceGCRx6LkMWOkw4zw9Qg1jo245nYGgoHB wOqnlNM91qNJMGvDy2wa =xHYH -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--