From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFLgZ-0006vG-9P for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:21:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFLgY-0005WM-Dk for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:21:15 -0400 Date: Wed, 15 Jul 2015 15:21:02 +0300 From: "Michael S. Tsirkin" Message-ID: <20150715151941-mutt-send-email-mst@redhat.com> References: <1436938201-16766-1-git-send-email-jasowang@redhat.com> <1436938201-16766-4-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436938201-16766-4-git-send-email-jasowang@redhat.com> Subject: Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com On Wed, Jul 15, 2015 at 01:29:59PM +0800, Jason Wang wrote: > Disable scsi passthrough by default since it was incompatible with > virtio 1.0. For legacy machine types, keep this on by default. > > Cc: Stefan Hajnoczi > Cc: Kevin Wolf > Cc: qemu-block@nongnu.org > Signed-off-by: Jason Wang Seems risky for 2.4. modern is off by default for now. Can't we limit the change to when modern is enabled? I suggested changing this from bool to on/off/auto, and make auto mean !modern. > --- > hw/block/virtio-blk.c | 2 +- > include/hw/compat.h | 6 +++++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index 761d763..362fe53 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -964,7 +964,7 @@ static Property virtio_blk_properties[] = { > DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial), > DEFINE_PROP_BIT("config-wce", VirtIOBlock, conf.config_wce, 0, true), > #ifdef __linux__ > - DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, true), > + DEFINE_PROP_BIT("scsi", VirtIOBlock, conf.scsi, 0, false), > #endif > DEFINE_PROP_BIT("request-merging", VirtIOBlock, conf.request_merging, 0, > true), > diff --git a/include/hw/compat.h b/include/hw/compat.h > index 4a43466..56039d8 100644 > --- a/include/hw/compat.h > +++ b/include/hw/compat.h > @@ -2,7 +2,11 @@ > #define HW_COMPAT_H > > #define HW_COMPAT_2_3 \ > - /* empty */ > + {\ > + .driver = "virtio-blk-pci",\ > + .property = "scsi",\ > + .value = "on",\ > + }, > > #define HW_COMPAT_2_2 \ > /* empty */ > -- > 2.1.4