From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFPG3-0002IN-VF for qemu-devel@nongnu.org; Wed, 15 Jul 2015 12:10:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFPFz-0003HC-8E for qemu-devel@nongnu.org; Wed, 15 Jul 2015 12:10:07 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:49527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFPFy-0002xw-Vf for qemu-devel@nongnu.org; Wed, 15 Jul 2015 12:10:03 -0400 Date: Wed, 15 Jul 2015 18:09:51 +0200 From: Aurelien Jarno Message-ID: <20150715160951.GC472@aurel32.net> References: <1436974021-28978-1-git-send-email-pbonzini@redhat.com> <1436974021-28978-2-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436974021-28978-2-git-send-email-pbonzini@redhat.com> Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 1/2] tcg: aarch64: add ext argument to tcg_out_insn_3310 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: claudio.fontana@huawei.com, qemu-devel@nongnu.org, rth@twiddle.net On 2015-07-15 17:27, Paolo Bonzini wrote: > The new argument lets you pick uxtw or uxtx mode for the offset > register. For now, all callers pass TCG_TYPE_I64 so that uxtx > is generated. The bits for uxtx are removed from I3312_TO_I3310. > > Reported-by: Leon Alrae > Signed-off-by: Paolo Bonzini > --- > tcg/aarch64/tcg-target.c | 41 ++++++++++++++++++++++------------------- > 1 file changed, 22 insertions(+), 19 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index fe44ad7..5395202 100644 > --- a/tcg/aarch64/tcg-target.c > +++ b/tcg/aarch64/tcg-target.c > @@ -280,7 +280,7 @@ typedef enum { > I3312_LDRSHX = 0x38000000 | LDST_LD_S_X << 22 | MO_16 << 30, > I3312_LDRSWX = 0x38000000 | LDST_LD_S_X << 22 | MO_32 << 30, > > - I3312_TO_I3310 = 0x00206800, > + I3312_TO_I3310 = 0x00200800, > I3312_TO_I3313 = 0x01000000, > > /* Load/store register pair instructions. */ > @@ -496,13 +496,14 @@ static void tcg_out_insn_3509(TCGContext *s, AArch64Insn insn, TCGType ext, > } > > static void tcg_out_insn_3310(TCGContext *s, AArch64Insn insn, > - TCGReg rd, TCGReg base, TCGReg regoff) > + TCGReg rd, TCGReg base, TCGType ext, > + TCGReg regoff) > { > /* Note the AArch64Insn constants above are for C3.3.12. Adjust. */ > - tcg_out32(s, insn | I3312_TO_I3310 | regoff << 16 | base << 5 | rd); > + tcg_out32(s, insn | I3312_TO_I3310 | regoff << 16 | > + 0x4000 | ext << 13 | base << 5 | rd); > } > > - > static void tcg_out_insn_3312(TCGContext *s, AArch64Insn insn, > TCGReg rd, TCGReg rn, intptr_t offset) > { > @@ -677,7 +678,7 @@ static void tcg_out_ldst(TCGContext *s, AArch64Insn insn, > > /* Worst-case scenario, move offset to temp register, use reg offset. */ > tcg_out_movi(s, TCG_TYPE_I64, TCG_REG_TMP, offset); > - tcg_out_ldst_r(s, insn, rd, rn, TCG_REG_TMP); > + tcg_out_ldst_r(s, insn, rd, rn, TCG_TYPE_I64, TCG_REG_TMP); > } > > static inline void tcg_out_mov(TCGContext *s, > @@ -1111,48 +1112,49 @@ static void tcg_out_qemu_ld_direct(TCGContext *s, TCGMemOp memop, TCGType ext, > TCGReg data_r, TCGReg addr_r, TCGReg off_r) > { > const TCGMemOp bswap = memop & MO_BSWAP; > + const TCGType otype = TCG_TYPE_I64; > > switch (memop & MO_SSIZE) { > case MO_UB: > - tcg_out_ldst_r(s, I3312_LDRB, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_LDRB, data_r, addr_r, otype, off_r); > break; > case MO_SB: > tcg_out_ldst_r(s, ext ? I3312_LDRSBX : I3312_LDRSBW, > - data_r, addr_r, off_r); > + data_r, addr_r, otype, off_r); > break; > case MO_UW: > - tcg_out_ldst_r(s, I3312_LDRH, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_LDRH, data_r, addr_r, otype, off_r); > if (bswap) { > tcg_out_rev16(s, data_r, data_r); > } > break; > case MO_SW: > if (bswap) { > - tcg_out_ldst_r(s, I3312_LDRH, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_LDRH, data_r, addr_r, otype, off_r); > tcg_out_rev16(s, data_r, data_r); > tcg_out_sxt(s, ext, MO_16, data_r, data_r); > } else { > - tcg_out_ldst_r(s, ext ? I3312_LDRSHX : I3312_LDRSHW, > - data_r, addr_r, off_r); > + tcg_out_ldst_r(s, (ext ? I3312_LDRSHX : I3312_LDRSHW), > + data_r, addr_r, otype, off_r); > } > break; > case MO_UL: > - tcg_out_ldst_r(s, I3312_LDRW, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_LDRW, data_r, addr_r, otype, off_r); > if (bswap) { > tcg_out_rev32(s, data_r, data_r); > } > break; > case MO_SL: > if (bswap) { > - tcg_out_ldst_r(s, I3312_LDRW, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_LDRW, data_r, addr_r, otype, off_r); > tcg_out_rev32(s, data_r, data_r); > tcg_out_sxt(s, TCG_TYPE_I64, MO_32, data_r, data_r); > } else { > - tcg_out_ldst_r(s, I3312_LDRSWX, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_LDRSWX, data_r, addr_r, otype, off_r); > } > break; > case MO_Q: > - tcg_out_ldst_r(s, I3312_LDRX, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_LDRX, data_r, addr_r, otype, off_r); > if (bswap) { > tcg_out_rev64(s, data_r, data_r); > } > @@ -1166,31 +1168,32 @@ static void tcg_out_qemu_st_direct(TCGContext *s, TCGMemOp memop, > TCGReg data_r, TCGReg addr_r, TCGReg off_r) > { > const TCGMemOp bswap = memop & MO_BSWAP; > + const TCGType otype = TCG_TYPE_I64; > > switch (memop & MO_SIZE) { > case MO_8: > - tcg_out_ldst_r(s, I3312_STRB, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_STRB, data_r, addr_r, otype, off_r); > break; > case MO_16: > if (bswap && data_r != TCG_REG_XZR) { > tcg_out_rev16(s, TCG_REG_TMP, data_r); > data_r = TCG_REG_TMP; > } > - tcg_out_ldst_r(s, I3312_STRH, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_STRH, data_r, addr_r, otype, off_r); > break; > case MO_32: > if (bswap && data_r != TCG_REG_XZR) { > tcg_out_rev32(s, TCG_REG_TMP, data_r); > data_r = TCG_REG_TMP; > } > - tcg_out_ldst_r(s, I3312_STRW, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_STRW, data_r, addr_r, otype, off_r); > break; > case MO_64: > if (bswap && data_r != TCG_REG_XZR) { > tcg_out_rev64(s, TCG_REG_TMP, data_r); > data_r = TCG_REG_TMP; > } > - tcg_out_ldst_r(s, I3312_STRX, data_r, addr_r, off_r); > + tcg_out_ldst_r(s, I3312_STRX, data_r, addr_r, otype, off_r); > break; > default: > tcg_abort(); Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net