From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFjYW-0001GT-BA for qemu-devel@nongnu.org; Thu, 16 Jul 2015 09:50:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFjYR-0007N0-Oo for qemu-devel@nongnu.org; Thu, 16 Jul 2015 09:50:32 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:33049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFjYR-0007Mu-HA for qemu-devel@nongnu.org; Thu, 16 Jul 2015 09:50:27 -0400 Received: by widic2 with SMTP id ic2so15841519wid.0 for ; Thu, 16 Jul 2015 06:50:26 -0700 (PDT) Date: Thu, 16 Jul 2015 14:50:22 +0100 From: Stefan Hajnoczi Message-ID: <20150716135022.GA21764@stefanha-thinkpad.redhat.com> References: <1436864116-19154-1-git-send-email-shmulik.ladkani@ravellosystems.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: <1436864116-19154-1-git-send-email-shmulik.ladkani@ravellosystems.com> Subject: Re: [Qemu-devel] [PATCH 0/2] vmxnet3: Fix RX TCP/UDP checksum of partially summed packets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shmulik Ladkani Cc: Dmitry Fleytman , idan.brown@ravellosystems.com, qemu-devel@nongnu.org, dana.rubin@ravellosystems.com --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2015 at 11:55:14AM +0300, Shmulik Ladkani wrote: > In case csum offloaded packet, vmxnet3 implementation always passes an > RxCompDesc with the "Checksum calculated and found correct" notification > to the OS. This emulates the observed ESXi behavior. >=20 > Therefore, if packet has the NEEDS_CSUM bit set, we must calculate and > place a fully computed checksum into the tcp/udp header. Otherwise, the > OS driver will receive a checksum-correct indication but with the actual > tcp/udp checksum field having just the pseudo header csum value. >=20 > Fix, by converting partially summed packets to be fully checksummed. >=20 > Shmulik Ladkani: > net/vmxnet3: Refactor 'vmxnet_rx_pkt_attach_data' >=20 > Dana Rubin: > net/vmxnet3: Fix RX TCP/UDP checksum on partially summed packets >=20 > hw/net/vmxnet3.c | 59 ++++++++++++++++++++++++++++++++++++++++++++= ++++++ > hw/net/vmxnet_rx_pkt.c | 12 +++++++--- > hw/net/vmxnet_rx_pkt.h | 11 ++++++++++ > 3 files changed, 79 insertions(+), 3 deletions(-) >=20 > --=20 > 1.9.1 >=20 >=20 Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan --PNTmBPCT7hxwcZjr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVp7aeAAoJEJykq7OBq3PIsIIH/03NG8hwU84WH2WInGEcWnME RspfqWnxRaPhBZbOxJ4AxJGpfOJpYH4UtWwSiDm0rYYPdpv1nRmlRwppqGIQA+ea x7AD3LPoD37OW4/qmkw8HZwprRR1rgEgMm/ftFKUyM1oPptm36YBjbOvZCUX+/OD 7lyf0+gCOXKEPajWFxJIBeid38TP/zM+xWFngqQ28q3zg94M6fXlAo4+1l+Z/+26 QIrNSnNV3/uX7A1Gs9sX0Cdhj4XUdxX/WiQrXJa5bbFSMvCfulD4fC2alZjSRsRm ISFE2K7jIvakXFFNm8Xu+BR4Mit6f7NtNiCfR5SKMle95TFZvZ91Fv+8jPlScv4= =0jrM -----END PGP SIGNATURE----- --PNTmBPCT7hxwcZjr--