From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG0or-00022m-DG for qemu-devel@nongnu.org; Fri, 17 Jul 2015 04:16:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZG0om-0001Zb-4I for qemu-devel@nongnu.org; Fri, 17 Jul 2015 04:16:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG0ol-0001ZU-VQ for qemu-devel@nongnu.org; Fri, 17 Jul 2015 04:16:28 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 985C63CCB54 for ; Fri, 17 Jul 2015 08:16:27 +0000 (UTC) Date: Fri, 17 Jul 2015 09:16:25 +0100 From: Stefan Hajnoczi Message-ID: <20150717081625.GA16079@stefanha-thinkpad.redhat.com> References: <1432322539-23719-1-git-send-email-thuth@redhat.com> <20150526125235.GJ13262@stefanha-thinkpad.redhat.com> <87egm34dk0.fsf@blackfin.pond.sub.org> <55A8A654.5070003@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <55A8A654.5070003@redhat.com> Subject: Re: [Qemu-devel] net: Next steps to deprecate -net (was: [RFC PATCH] Enable vlans and dump for -netdev, too) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Jason Wang , "Michael S. Tsirkin" , Markus Armbruster , qemu-devel@nongnu.org --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 17, 2015 at 08:53:08AM +0200, Thomas Huth wrote: > On 05/26/2015 04:29 PM, Markus Armbruster wrote: > > Stefan Hajnoczi writes: > [...] > >> We thought the QEMU "vlan" concept would be dropped completely in the > >> future, so it was never added to -netdev. No patches to do that have > >> been posted over the years, so I think it was more of a conceptual goal > >> than a concrete requirement. > >=20 > > Well, patches to do that first need to replace the VLAN-only dump > > feature. > >=20 > > To fully deprecate -net, we also have to replace -net nic for > > configuring onboard NICs. > >=20 > > Prior discussion: > > http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg03743.html > >=20 > > We haven't really tried either. >=20 > Ok, assuming that my "Network traffic dumping for -netdev devices" patch > series is going to solve the dumping-for-netdev problem, how do we > tackle the remaining problems that we have to solve before we can > deprecate -net? Does anybody have a survey of the (onboard) NICs that > can only be configured with -net but not with -device? Could they > nowadays be changed to work with -device, too, or are there still major > obstacles to solve first? Take a look at nd_table[] and nb_nics. That's the array of -net nic devices. The boards look into the array to grab NICs. The default NIC is set in net_init_clients() as a "-net nic" option. The weird thing about "-net nic" is that the device is not created in net/net.c by the "-net nic" command-line option. It just adds the information to the nd_table[] array. It's the board that has to instantiate nd_table[] entries. For example, pc_nic_init() adds devices for x86 guests. That's about all I know or have thought about so far. It would be nice to get rid of -net but it will take some work and is a QEMU 3.0 feature since it breaks backwards compatibility. --azLHFNyN32YCQGCU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVqLnZAAoJEJykq7OBq3PILQsIAId1N2ArhI0nts68tiLu5C0f THiAoOfC4rSjCTgBqvnPuHvjRH6BfwM8Bfol0bnJF/8stGHhqsnoVBB/gs+9JDg0 tRyk8EgXfILAJytMJlsbOg4kLxYvScQ0syWcCRSkoUeg61P1uTSNWgdgXkryFmsy m1CJDDgOM1lMttX5/YXxefNn1tkYginsGwihTf8yVXHgYbzKkCc+j4+JP226l73x ZGyb5InFZLPVw51Y19Aq3lorSUsLsWgsThc1yYpC/3V0p4Oiz+dXM78jOKWN0JIg NJBfmJTFrUQ9RCOXEUmlHGdjkDcl9+0rkhN1/4TMQhZML/DdPgvodHJjhoUmts4= =MRWg -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--