qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] crypto/cipher-nettle.c: Pass correct function type to cbc_encrypt and cbc_decrypt.
Date: Fri, 17 Jul 2015 11:47:27 +0100	[thread overview]
Message-ID: <20150717104727.GD4835@redhat.com> (raw)
In-Reply-To: <1437040522-19799-1-git-send-email-rjones@redhat.com>

On Thu, Jul 16, 2015 at 10:55:22AM +0100, Richard W.M. Jones wrote:
> The prototypes of the {nettle_}cbc_encrypt and cbc_decrypt functions
> are:
> 
> void
> cbc_encrypt(const void *ctx, nettle_cipher_func *f,
>             size_t block_size, uint8_t *iv,
>             size_t length, uint8_t *dst,
>             const uint8_t *src);
> 
> void
> cbc_decrypt(const void *ctx, nettle_cipher_func *f,
>             size_t block_size, uint8_t *iv,
>             size_t length, uint8_t *dst,
>             const uint8_t *src);
> 
> Since we passed nettle_crypt_func (instead of nettle_cipher_func) as
> the second argument, this gave the errors below.

Presumably you used Fedora rawhide which will have nettle 3.x
where as my code was written against FEdora 22 nettle 2.7.x
The function prototypes were changed in 3.x, so we need a
conditional fix - one was just sent in a pull request yesterday:

  https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg03678.html

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

      parent reply	other threads:[~2015-07-17 10:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16  9:55 [Qemu-devel] [PATCH] crypto/cipher-nettle.c: Pass correct function type to cbc_encrypt and cbc_decrypt Richard W.M. Jones
2015-07-16 10:04 ` Peter Maydell
2015-07-16 10:08   ` Paolo Bonzini
2015-07-16 10:12     ` Peter Maydell
2015-07-16 10:28   ` Richard W.M. Jones
2015-07-17 10:47 ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150717104727.GD4835@redhat.com \
    --to=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).