From: "Daniel P. Berrange" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, "Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 3/3] crypto: use CPP for wrapper definitions in nettle
Date: Fri, 17 Jul 2015 12:00:08 +0100 [thread overview]
Message-ID: <20150717110008.GI4835@redhat.com> (raw)
In-Reply-To: <55A7D7A0.90805@redhat.com>
On Thu, Jul 16, 2015 at 06:11:12PM +0200, Paolo Bonzini wrote:
>
>
> On 16/07/2015 18:04, Radim Krčmář wrote:
> > It's horrible both ways and I prefer this one.
>
> Let's see what Dan thinks. Since he's on vacation, for now I'm applying
> patches 1 and 2 only.
I don't have a strong opinion on patch 3 - personally I don't think
it is much benefit, but if you / other maintainers like it, I'd be
fine with it being merged.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2015-07-17 11:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 16:03 [Qemu-devel] [PATCH v3 0/3] crypto: nettle fixes Radim Krčmář
2015-07-16 16:03 ` [Qemu-devel] [PATCH v3 1/3] crypto: fix build with nettle >= 3.0.0 Radim Krčmář
2015-07-17 10:54 ` Daniel P. Berrange
2015-07-16 16:04 ` [Qemu-devel] [PATCH v3 2/3] crypto: avoid undefined behavior in nettle calls Radim Krčmář
2015-07-17 10:55 ` Daniel P. Berrange
2015-07-17 17:43 ` Kevin Wolf
2015-07-16 16:04 ` [Qemu-devel] [PATCH v3 3/3] crypto: use CPP for wrapper definitions in nettle Radim Krčmář
2015-07-16 16:11 ` Paolo Bonzini
2015-07-17 11:00 ` Daniel P. Berrange [this message]
2015-07-17 11:00 ` Paolo Bonzini
2015-07-17 10:58 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717110008.GI4835@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).