From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG3NI-0006ks-UL for qemu-devel@nongnu.org; Fri, 17 Jul 2015 07:00:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZG3NF-000066-80 for qemu-devel@nongnu.org; Fri, 17 Jul 2015 07:00:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG3NF-00005v-3l for qemu-devel@nongnu.org; Fri, 17 Jul 2015 07:00:13 -0400 Date: Fri, 17 Jul 2015 12:00:08 +0100 From: "Daniel P. Berrange" Message-ID: <20150717110008.GI4835@redhat.com> References: <1437062641-12684-1-git-send-email-rkrcmar@redhat.com> <1437062641-12684-4-git-send-email-rkrcmar@redhat.com> <55A7D7A0.90805@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55A7D7A0.90805@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 3/3] crypto: use CPP for wrapper definitions in nettle Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , qemu-devel@nongnu.org, Radim =?utf-8?B?S3LEjW3DocWZ?= On Thu, Jul 16, 2015 at 06:11:12PM +0200, Paolo Bonzini wrote: >=20 >=20 > On 16/07/2015 18:04, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > > It's horrible both ways and I prefer this one. >=20 > Let's see what Dan thinks. Since he's on vacation, for now I'm applyin= g > patches 1 and 2 only. I don't have a strong opinion on patch 3 - personally I don't think it is much benefit, but if you / other maintainers like it, I'd be fine with it being merged. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|