From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] blockdev: warn about aio=native if libaio is unavailable
Date: Fri, 17 Jul 2015 14:57:56 +0100 [thread overview]
Message-ID: <20150717135756.GG6572@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20150717105615.GB4622@noname.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Fri, Jul 17, 2015 at 12:56:15PM +0200, Kevin Wolf wrote:
> Am 17.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben:
> > QEMU silently ignores aio=native if libaio is unavailable. It is
> > confusing when aio=native performance is identical to aio=threads
> > because the binary was accidentally built without libaio.
> >
> > Use error_report() because failing would break backward compatibility.
> > There are probably users using aio=native who would be inconvenienced if
> > QEMU suddenly refused to start their guests.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> I hope not too many people are using aio=native without having libaio
> compiled in... Can we make it a message like for the case with
> aio=native,cache.direct=off, i.e. a deprecation warning that allows us
> to make this an error in a few releases?
Yes, I'll move the warning to raw-posix.c so all callers benefit from
it.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-07-17 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 9:59 [Qemu-devel] [PATCH] blockdev: warn about aio=native if libaio is unavailable Stefan Hajnoczi
2015-07-17 10:56 ` Kevin Wolf
2015-07-17 13:57 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717135756.GG6572@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).