From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZH2jY-0002Q8-LS for qemu-devel@nongnu.org; Mon, 20 Jul 2015 00:31:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZH2jW-0002pV-Kp for qemu-devel@nongnu.org; Mon, 20 Jul 2015 00:31:20 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:47017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZH2jW-0002ng-2h for qemu-devel@nongnu.org; Mon, 20 Jul 2015 00:31:18 -0400 Date: Mon, 20 Jul 2015 14:02:33 +1000 From: David Gibson Message-ID: <20150720040233.GD19189@voom.fritz.box> References: <1437134200-13086-1-git-send-email-drjones@redhat.com> <1437134200-13086-2-git-send-email-drjones@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UfEAyuTBtIjiZzX6" Content-Disposition: inline In-Reply-To: <1437134200-13086-2-git-send-email-drjones@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH 1/2] spapr: add dumpdtb support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: dgibson@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, agraf@suse.de --UfEAyuTBtIjiZzX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 17, 2015 at 01:56:39PM +0200, Andrew Jones wrote: > Signed-off-by: Andrew Jones Looks good to me, but I'd like an actual commit message: what's dumpdtb, how and why would you use it. > --- > hw/ppc/spapr.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index a6f19473cf278..c1cbf3387ae0c 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -30,6 +30,7 @@ > #include "hw/fw-path-provider.h" > #include "elf.h" > #include "net/net.h" > +#include "sysemu/device_tree.h" > #include "sysemu/block-backend.h" > #include "sysemu/cpus.h" > #include "sysemu/kvm.h" > @@ -822,6 +823,7 @@ static void spapr_finalize_fdt(sPAPRMachineState *spa= pr, > exit(1); > } > =20 > + qemu_fdt_dumpdtb(fdt, fdt_totalsize(fdt)); > cpu_physical_memory_write(fdt_addr, fdt, fdt_totalsize(fdt)); > =20 > g_free(bootlist); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --UfEAyuTBtIjiZzX6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVrHLZAAoJEGw4ysog2bOSeWgP/jNwBNUAHBSe40ji4RjqdfF/ GWD8zzZpMeONz+ckhjyZS2MnN/iZGfeOTa7r/Yh41epOCl8yRYUAIWaO+B5Jnr9t cxGpvdfSagNybxQozRVEYVZ365QZC8H1RmLldx+1WdX+iYkziSw1BuDOBfxn6crK VtTjpeTayyUsY8E8Zk70F/Nr5mgmgaOUHBHV6f5zy7aDrLWXRrEbD0GfrqwSYVp+ 3UuvWWVYvr/nfPOKVU+XNQDxHs/7G3MTCzbokZfGpW9RUZ/kyJDb/FDwer6qEGL1 DkjjygP5zQgV8mkhntl2kG5H1O0xK70hNwRFPXrmDvbAr2XbhKWx4VbR1wOqeQQp oMvz+PKDXwDOSM/4M2U5ZtQdSZ5AjIO6FQStNggltkMCAZMpvWp7UlNTAyBxY5bT U8tD2U9srX7am25t2fHqcNslmpn5ukORA7RczENNjhs8UjM3vUpJ6wpM4AlBtpBN DdaLOEtg2QLNQSJDZvH6exSrA7t2Bhr37lqHGKCczo7Hw0KnDUnwGAjZmsdAZ/U8 Rg+smIAGyRehelXtGClElgGwJ4lCP+9OrsQ7t04dVKloSjWGnAVZqugls0v0QAve wxh7MYY73rZreVOm39TCahDgQtXqXU0zcJDARH7oykD25UxGXmk8xLhff906sowh WpEiQuQ0tXU7o55Yl8qN =720R -----END PGP SIGNATURE----- --UfEAyuTBtIjiZzX6--