From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHDHO-0003vy-93 for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:46:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHDHK-0007BG-8T for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:46:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHDHK-0007Ay-3f for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:46:54 -0400 Date: Mon, 20 Jul 2015 16:46:49 +0100 From: Stefan Hajnoczi Message-ID: <20150720154649.GL12675@stefanha-thinkpad.redhat.com> References: <1437151464-5458-1-git-send-email-mitake.hitoshi@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E6lVPAHcXg6biC3t" Content-Disposition: inline In-Reply-To: <1437151464-5458-1-git-send-email-mitake.hitoshi@lab.ntt.co.jp> Subject: Re: [Qemu-devel] [PATCH] sheepdog: serialize requests to overwrapping area List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hitoshi Mitake Cc: Kevin Wolf , Teruaki Ishizaki , Jeff Cody , qemu-devel@nongnu.org, Vasiliy Tolstov , sheepdog@lists.wpkg.org --E6lVPAHcXg6biC3t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 18, 2015 at 01:44:24AM +0900, Hitoshi Mitake wrote: > Current sheepdog driver only serializes create requests in oid > unit. This mechanism isn't enough for handling requests to > overwrapping area spanning multiple oids, so it can result bugs like > below: > https://bugs.launchpad.net/sheepdog-project/+bug/1456421 >=20 > This patch adds a new serialization mechanism for the problem. The > difference from the old one is: > 1. serialize entire aiocb if their targetting areas overwrap > 2. serialize all requests (read, write, and discard), not only creates >=20 > This patch also removes the old mechanism because the new one can be > an alternative. >=20 > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Cc: Teruaki Ishizaki > Cc: Vasiliy Tolstov > Signed-off-by: Hitoshi Mitake > --- > block/sheepdog.c | 152 ++++++++++++++++++++++++++-----------------------= ------ > 1 file changed, 71 insertions(+), 81 deletions(-) CCing Jeff Cody who now handles pull requests for network protocols. --E6lVPAHcXg6biC3t Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVrRfpAAoJEJykq7OBq3PIedwIAKgdf1pfLsDBjRTmJFLaPKs9 YJFq2Fw8t0EmQQyMofEekFCX5ZEwl7Q+3JRzDR5kKs5fSdUmJSB2XxFNkMnHtJd6 FqqK/qObiU36zkM5o9Ee7V+KDox7Hg4kvBqX0853M8WT0P1Rs299RZhzWO6akWZF D+c9UocTTQow0QQmgFe6vf7nwweSTmaNNe4VT3AYhn+nqfHRxhGHvRzYvBxDrwUD nR4TrHHQVN5Y8i0hUJL5p3vSLODALo97gSwrxDvUzwZuwe9SkdhMIIe2e99O/QTY dVxdl7QRDVXz+bdp0jOw7l2gSVWPcQo0o5EGhsG1Vx40WTuYo0aRGq2vD3qpcGs= =IUIq -----END PGP SIGNATURE----- --E6lVPAHcXg6biC3t--