From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHqNV-0000cv-0G for qemu-devel@nongnu.org; Wed, 22 Jul 2015 05:31:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHqNR-0000GD-Ib for qemu-devel@nongnu.org; Wed, 22 Jul 2015 05:31:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHqNR-0000G2-EP for qemu-devel@nongnu.org; Wed, 22 Jul 2015 05:31:49 -0400 Date: Wed, 22 Jul 2015 10:31:45 +0100 From: "Daniel P. Berrange" Message-ID: <20150722093145.GD12010@redhat.com> References: <1437544792-3949-1-git-send-email-jasowang@redhat.com> <1437544792-3949-3-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1437544792-3949-3-git-send-email-jasowang@redhat.com> Subject: Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: cornelia.huck@de.ibm.com, pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: > SCSI passthrough was no longer supported in virtio 1.0, so this patch > fail the get_features() when both 1.0 and scsi is set. And also only > advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. Why is SCSI passthrough support not available in virtio 1.0 ? This will cause a regression for any users of that as & when QEMU changes to use virtio 1.0 by default. Can we not fix this regression instead. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|