From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHpfW-0001Ij-7E for qemu-devel@nongnu.org; Wed, 22 Jul 2015 04:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHpfS-0003R3-6B for qemu-devel@nongnu.org; Wed, 22 Jul 2015 04:46:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHpfS-0003Qy-1K for qemu-devel@nongnu.org; Wed, 22 Jul 2015 04:46:22 -0400 Date: Wed, 22 Jul 2015 10:46:16 +0200 From: Marc =?UTF-8?B?TWFyw60=?= Message-ID: <20150722104616.78d636e1@markmb_rh> In-Reply-To: <55AEA322.3050104@redhat.com> References: <1437494626-3773-1-git-send-email-markmb@redhat.com> <1437494626-3773-6-git-send-email-markmb@redhat.com> <55AEA322.3050104@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Stefan Hajnoczi , Kevin O'Connor , Gerd Hoffmann , qemu-devel , Paolo Bonzini On Tue, 21 Jul 2015 21:53:06 +0200 Laszlo Ersek wrote: > On 07/21/15 18:18, Stefan Hajnoczi wrote: > > On Tue, Jul 21, 2015 at 5:03 PM, Marc Mar=C3=AD > > wrote: > >> From: Gerd Hoffmann > >> > >> This is what it takes to have a sorted fw_cfg file directory. > >> Entries are inserted at the correct place instead of being > >> appended to the end in case sorting is enabled. > >> > >> Compatibility fluff (enable sorting for new machine types only) > >> isn't there yet. > >> > >> Signed-off-by: Gerd Hoffmann > >> --- > >> hw/nvram/fw_cfg.c | 30 ++++++++++++++++++++++++------ > >> 1 file changed, 24 insertions(+), 6 deletions(-) > >=20 > > Probably best to drop this patch from this series, unless it's > > needed. > >=20 > > I guess sorting files allows for binary search but it's unrelated to > > DMA and needs to be accompanied with guest code (e.g. SeaBIOS) that > > actually uses the feature. >=20 > I recall another discussion where the sorting was considered under a > migration aspect (not for the sake of binary search on the guest > side). >=20 > .... Yes, here it is: >=20 > http://thread.gmane.org/gmane.comp.emulators.qemu/340424/focus=3D342398 >=20 > The commit message should give a full rationale, preferably. >=20 I've not worked on it, it was already on the patches. So I'll drop it for now, and it can be retaken in the future. Thanks Marc