From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47461)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <markmb@redhat.com>) id 1ZHpzG-0008Gi-H9
	for qemu-devel@nongnu.org; Wed, 22 Jul 2015 05:06:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <markmb@redhat.com>) id 1ZHpzB-0005Au-JJ
	for qemu-devel@nongnu.org; Wed, 22 Jul 2015 05:06:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51881)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <markmb@redhat.com>) id 1ZHpzB-0005Am-EH
	for qemu-devel@nongnu.org; Wed, 22 Jul 2015 05:06:45 -0400
Date: Wed, 22 Jul 2015 11:06:39 +0200
From: Marc =?UTF-8?B?TWFyw60=?= <markmb@redhat.com>
Message-ID: <20150722110639.3249c891@markmb_rh>
In-Reply-To: <CAFEAcA9CMETgy5ufCubLNvSnMM5ut5TVcqyCh6ZHGLvLK37TKA@mail.gmail.com>
References: <1437494626-3773-1-git-send-email-markmb@redhat.com>
	<1437494626-3773-8-git-send-email-markmb@redhat.com>
	<CAFEAcA9CMETgy5ufCubLNvSnMM5ut5TVcqyCh6ZHGLvLK37TKA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 7/7] fw_cfg DMA for x86
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Kevin O'Connor <kevin@koconnor.net>, QEMU Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On Tue, 21 Jul 2015 18:14:40 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 21 July 2015 at 17:03, Marc Mar=C3=AD <markmb@redhat.com> wrote:
> > Enable fw_cfg for x86 machines. Create new machine to avoid
> > incompatibilites.
>=20
> > @@ -1391,7 +1399,14 @@ FWCfgState *pc_memory_init(MachineState
> > *machine, option_rom_mr,
> >                                          1);
> >
> > -    fw_cfg =3D bochs_bios_init();
> > +    if (guest_info->fw_cfg_dma) {
> > +        as =3D g_malloc(sizeof(*as));
> > +        address_space_init(as, ram_below_4g, "pc.as");
> > +        fw_cfg =3D bochs_bios_init(as, BIOS_CFG_DMA_ADDR);
> > +    } else {
> > +        fw_cfg =3D bochs_bios_init(NULL, 0);
> > +    }
> > +
>=20
> As with ARM: what's the rationale for choosing this particular
> AddressSpace as the target for fw_cfg DMA? (I'm not saying it's
> wrong, necessarily -- I was just surprised we didn't just use
> the system address space.)
>=20
> thanks
> -- PMM

I took something that seemed logical for me, as the BIOS will be
working in 32 bits. But, as with ARM, I'm not really sure which
address space should I use for this purpose. I'd appreciate some help
in the issue.

Thanks
Marc