From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHtyh-0001wb-KW for qemu-devel@nongnu.org; Wed, 22 Jul 2015 09:22:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHtyc-0007IN-12 for qemu-devel@nongnu.org; Wed, 22 Jul 2015 09:22:31 -0400 Date: Wed, 22 Jul 2015 14:22:18 +0100 From: "Richard W.M. Jones" Message-ID: <20150722132218.GB22921@redhat.com> References: <1437570442-30203-1-git-send-email-rjones@redhat.com> <1437570442-30203-2-git-send-email-rjones@redhat.com> <20150722131749.GC21772@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150722131749.GC21772@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v2] block/ssh: Avoid segfault if inet_connect doesn't set errno. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org On Wed, Jul 22, 2015 at 09:17:49AM -0400, Jeff Cody wrote: > Both nbd and sheepdog handle it in a similar fashion (i.e. not relying > on errno being set on inet_connect failure). However, both nbd and > sheepdog use -EIO as the error return, and I think that makes more > sense. What do you think? If you prefer -- I don't mind as long as it doesn't segfault :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org