From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42013)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZHvRl-0001WI-Kf
	for qemu-devel@nongnu.org; Wed, 22 Jul 2015 10:56:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZHvRi-0004G9-AH
	for qemu-devel@nongnu.org; Wed, 22 Jul 2015 10:56:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47019)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZHvRi-0004G3-6G
	for qemu-devel@nongnu.org; Wed, 22 Jul 2015 10:56:34 -0400
Date: Wed, 22 Jul 2015 17:56:30 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150722175451-mutt-send-email-mst@redhat.com>
References: <1437544792-3949-1-git-send-email-jasowang@redhat.com>
	<1437544792-3949-3-git-send-email-jasowang@redhat.com>
	<20150722093145.GD12010@redhat.com>
	<20150722131342-mutt-send-email-mst@redhat.com>
	<55AF8129.50105@redhat.com> <20150722114611.GI12010@redhat.com>
	<55AF842A.1040508@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55AF842A.1040508@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when
 both scsi and 1.0 were set
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: cornelia.huck@de.ibm.com, libvir-list@redhat.com, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org

On Wed, Jul 22, 2015 at 01:53:14PM +0200, Paolo Bonzini wrote:
> 
> 
> On 22/07/2015 13:46, Daniel P. Berrange wrote:
> > IIUC, the SCSI passthrough feature for virtio-blk is enabled by
> > setting the 'scsi=on' property on the virtio-blk device, which is
> > exposed by libvirt with XML:
> > 
> >     <disk type='block' device='lun'>
> >       <driver name='qemu' type='raw'/>
> >       <source dev='/dev/sda'/>
> >       <target dev='vda' bus='virtio'/>
> >     </disk>
> > 
> > (For use with virtio-scsi you'd just change the <target> element)
> > 
> > So if the guest is using virtio-1.0, then this will now fail to boot, or
> > cause an error from monitor hotplug. This is not too bad, but I'm just
> > wondering if there's anything else we ought to think about doing in libvirt
> > in this situation. Normally we'd try to detect unsupported things upfront
> > so we can report VIR_ERR_CONFIG_UNSUPPORTED, instead of the generic error
> > code VIR_ERR_INTERNAL_ERROR, but perhaps this is sufficiently niche to
> > not worry about it and its fine to just delegate error reporting to QEMU ?
> 
> Probably.  Note that it will be a long time before the default is
> changed to 1.0 (if it ever will).

I fully expect we'll enable modern by default in 2.5.  We'll also
disable legacy if the bus used is pcie.  We can disable modern if bus is
pci and scsi passthrough was requested.

>  Perhaps you can start warning now
> about <disk type='block' device='lun'>, and suggest using virtio-scsi
> instead?
> 
> Paolo