From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58620)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZIFGm-0000TL-Fi
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 08:06:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZIFGi-0000lI-At
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 08:06:36 -0400
Date: Thu, 23 Jul 2015 13:06:12 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150723120612.GC16243@stefanha-thinkpad.redhat.com>
References: <1437143029-12100-1-git-send-email-stefanha@redhat.com>
	<87vbdbgv1n.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="XWOWbaMNXpFDWE00"
Content-Disposition: inline
In-Reply-To: <87vbdbgv1n.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if
 libaio is unavailable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org


--XWOWbaMNXpFDWE00
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 23, 2015 at 10:03:32AM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi <stefanha@redhat.com> writes:
>=20
> > v2:
> >  * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's busin=
ess
> >    [Kevin]
> >  * Print the warning in the same way as the aio=3Dnative,cache.direct=
=3Doff
> >    deprecation warning [Kevin]
> >
> > Open question: what about the Windows case?  We now pass the
> > FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=3Dna=
tive.
>=20
> Odd.  Commit a273652 takes the trouble to implement native asynchronous
> I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's
> unreachable, isn't it?  Paolo?
>=20
> I think PATCH 2's commit message needs to be updated to discuss the
> impact.

Nice find!

I'll send a v2.

--XWOWbaMNXpFDWE00
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJVsNi0AAoJEJykq7OBq3PIO48H/A+xwFybNgjuc5tGygMX4kLw
vGGj/jqTgpaIJe8nf91sD74Dpy4fpIHtBOnU9BE79ocfbHUCHcqehiJkSSBp3xr4
v8RyFs1jzg01Y8cTuvWdYEznJdQgGhIdlz+KAEFQHhGPEb5aYzrf4LGjiD77PTwt
trwLopcP61Dub2BC57OHfumrqTJIyuXOCWPCAghVr1y+p2lLW9fK2pKR0/Y1XICG
96dOacRz67ElQ2jaITda1hbbNTbNMpbJFCyVhOdrI4EtULRcjFkQCBulFx7ouaF7
XzSxNAxTGx9bBVNwtfIjFjlchOEjErzNmJw4hrF6TwwvdHI7w7O/P877jDDto5E=
=3LMR
-----END PGP SIGNATURE-----

--XWOWbaMNXpFDWE00--