From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIJHV-0000Cs-07 for qemu-devel@nongnu.org; Thu, 23 Jul 2015 12:23:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIJHR-0007Ct-Nb for qemu-devel@nongnu.org; Thu, 23 Jul 2015 12:23:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIJHR-0007CV-IO for qemu-devel@nongnu.org; Thu, 23 Jul 2015 12:23:33 -0400 Date: Thu, 23 Jul 2015 18:30:14 +0300 From: "Michael S. Tsirkin" Message-ID: <20150723182723-mutt-send-email-mst@redhat.com> References: <1437615403-13554-1-git-send-email-marcandre.lureau@redhat.com> <1437615403-13554-7-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1437615403-13554-7-git-send-email-marcandre.lureau@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 6/6] vhost-user: document migration log List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: thibaut.collet@6wind.com, pbonzini@redhat.com, qemu-devel@nongnu.org, haifeng.lin@huawei.com On Thu, Jul 23, 2015 at 03:36:43AM +0200, Marc-Andr=E9 Lureau wrote: > Signed-off-by: Marc-Andr=E9 Lureau for some reason I didn't get 5/6. > --- > docs/specs/vhost-user.txt | 40 +++++++++++++++++++++++++++++++++++++++= + > 1 file changed, 40 insertions(+) >=20 > diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt > index 0062baa..c2d2e2a 100644 > --- a/docs/specs/vhost-user.txt > +++ b/docs/specs/vhost-user.txt > @@ -120,6 +120,7 @@ There are several messages that the master sends wi= th file descriptors passed > in the ancillary data: > =20 > * VHOST_SET_MEM_TABLE > + * VHOST_SET_LOG_BASE (if VHOST_USER_PROTOCOL_F_LOG_SHMFD) > * VHOST_SET_LOG_FD > * VHOST_SET_VRING_KICK > * VHOST_SET_VRING_CALL > @@ -135,6 +136,11 @@ As older slaves don't support negotiating protocol= features, > a feature bit was dedicated for this purpose: > #define VHOST_USER_F_PROTOCOL_FEATURES 30 > =20 > +Protocol features > +----------------- > + > +#define VHOST_USER_PROTOCOL_F_LOG_SHMFD 0 > + > Message types > ------------- > =20 > @@ -301,3 +307,37 @@ Message types > Bits (0-7) of the payload contain the vring index. Bit 8 is the > invalid FD flag. This flag is set when there is no file descript= or > in the ancillary data. > + > +Migration > +--------- > + > +During live migration, the master may need to track the modifications > +the slave makes to the memory mapped regions. The client should mark > +the dirty pages in a log. Once it complies to this logging, it may > +declare VHOST_F_LOG_ALL has a vhost feature. > + > +All the modifications to memory pointed by vring "descriptor" should > +be marked. Modifications to "used" vring should be marked if > +VHOST_VRING_F_LOG is part of ring's features. It's device's features I think. > + > +Dirty pages are of size: > +#define VHOST_LOG_PAGE 0x1000 > + > +The log memory fd is provided in the ancillary data of > +VHOST_USER_SET_LOG_BASE message when the slave has > +VHOST_USER_PROTOCOL_F_LOG_SHMFD protocol feature. > + > +The size of the log may be computed by using all the known guest > +addresses. The log covers from address 0 to the maximum of guest > +regions. In pseudo-code, to mark page at "addr" as dirty: > + > +page =3D addr / VHOST_LOG_PAGE > +log[page / 8] |=3D 1 << page % 8 Pls note it must be done atomically. > + > +VHOST_USER_SET_LOG_FD is an optional message with an eventfd in > +ancillary data, it may be used to inform the master that the log has > +been modified. > + > +Once the source has finished migration, VHOST_USER_RESET_OWNER message > +will be sent by the source. No further update must be done before the > +destination takes over with new regions & rings. > --=20 > 2.4.3