From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZIOWu-00031U-U8
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 17:59:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZIOWt-0008SG-Pg
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 17:59:52 -0400
Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:48254)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZIOWt-0008RO-Jl
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 17:59:51 -0400
Date: Thu, 23 Jul 2015 23:59:48 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150723215948.GM11361@aurel32.net>
References: <2692911436348920@web2m.yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2692911436348920@web2m.yandex.ru>
Subject: Re: [Qemu-devel] [PATCH] target-i386/FPU: a misprint in
 helper_fistll_ST0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Poletaev <poletaev-qemu@yandex.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Eduardo Habkost <ehabkost@redhat.com>, Richard Henderson <rth@twiddle.net>

On 2015-07-08 12:48, Dmitry Poletaev wrote:
> There is a misprint in the patch https://lists.gnu.org/archive/html/qemu-devel/2014-11/msg01657.html . It cause errors in guest work.
> Here is the bugfix.
> 
> From: Dmitry Poletaev <poletaev-qemu@yandex.ru>
> Signed-off-by: Dmitry Poletaev <poletaev-qemu@yandex.ru>
> Reported-by: Kirill Batuzov <batuzovk@ispras.ru>
> 
> ---
>  target-i386/fpu_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
> index fc25a03..fcf400d 100644
> --- a/target-i386/fpu_helper.c
> +++ b/target-i386/fpu_helper.c
> @@ -273,7 +273,7 @@ int64_t helper_fistll_ST0(CPUX86State *env)
>      old_exp_flags = get_float_exception_flags(&env->fp_status);
>      set_float_exception_flags(0, &env->fp_status);
>      
> -    val = floatx80_to_int32(ST0, &env->fp_status);
> +    val = floatx80_to_int64(ST0, &env->fp_status);
>      if (get_float_exception_flags(&env->fp_status) & float_flag_invalid) {
>          val = 0x8000000000000000ULL;
>      }

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

Adding the maintainers of target-i386 in the loop so they might pick-up
the patch for 2.4.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net