From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZIOrd-0004g6-GI
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 18:21:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZIOra-0001oa-77
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 18:21:17 -0400
Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:48386)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZIOra-0001oT-0O
	for qemu-devel@nongnu.org; Thu, 23 Jul 2015 18:21:14 -0400
Date: Fri, 24 Jul 2015 00:21:11 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150723222111.GA20361@aurel32.net>
References: <1437689640-31364-1-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1437689640-31364-1-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] tcg/aarch64: use 32-bit offset for 32-bit
 softmmu emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Claudio Fontana <claudio.fontana@huawei.com>, qemu-devel@nongnu.org

On 2015-07-23 15:14, Richard Henderson wrote:
> Similar to the same fix for user-mode, except this instance
> ocurrs on the softmmu path.  Again, the softmmu addend must
> be the base register, while the guest address is the index.
> 
> Cc: Claudio Fontana <claudio.fontana@huawei.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> 
> While applying Paolo's fix for user-mode, I noticed this.
> I've never seen this fail, but obviously what we have is wrong.
> 
> This patch depends on Paolo's cleanup.
> 
> 
> r~
> ---
>  tcg/aarch64/tcg-target.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Good catch!

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>


-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net