From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZIdpQ-0000nj-Il
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 10:20:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZIdpM-0003U8-Sr
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 10:20:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33326)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZIdpM-0003U2-OL
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 10:19:56 -0400
Date: Fri, 24 Jul 2015 15:19:52 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150724141952.GS6880@redhat.com>
References: <CAFEAcA_EDfhFQKkbnGo3tXaj3hQ+uQkQnXdQ8p=bmD-S1_ej8g@mail.gmail.com>
	<20150724125238.GA12473@redhat.com> <55B23556.2080302@redhat.com>
	<CAFEAcA8f2x5R5ujVzB8bviYDGzMwz+WFCg9=PsZRWPjf6zV_qQ@mail.gmail.com>
	<CAFEAcA-ojp-9kTocUTJnfP8W4b01zQxS-2Ew9TY7UXGkzwhSNQ@mail.gmail.com>
	<20150724131002.GM6880@redhat.com>
	<CAFEAcA_bSsmkrMAvArXhYs=cs-ESJQwC1+aH4=L6vk9a4NDc-A@mail.gmail.com>
	<55B243EC.2060406@redhat.com> <20150724141449.GR6880@redhat.com>
	<55B24883.3060406@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <55B24883.3060406@redhat.com>
Subject: Re: [Qemu-devel] [PULL v3 00/12] Final changes for 2.4-rc0
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

On Fri, Jul 24, 2015 at 04:15:31PM +0200, Paolo Bonzini wrote:
> 
> 
> On 24/07/2015 16:14, Daniel P. Berrange wrote:
> >> > diff --git a/Makefile.objs b/Makefile.objs
> >> > index f094eff..9d988d9 100644
> >> > --- a/Makefile.objs
> >> > +++ b/Makefile.objs
> >> > @@ -2,7 +2,9 @@
> >> >  # Common libraries for tools and emulators
> >> >  stub-obj-y = stubs/
> >> >  util-obj-y = util/ qobject/ qapi/ qapi-types.o qapi-visit.o qapi-event.o
> >> > -util-obj-y += crypto/
> >> > +
> >> > +util-obj-$(call notempty,$(TOOLS)) += crypto/
> >> > +util-obj-$(CONFIG_SOFTMMU) += crypto/
> > I have a feeling that'd cause the test suite to fail to link,
> > because it expects it to be unconditionally present in the
> > libqemuutil.a lib.
> 
> Right...  We need to introduce CONFIG_CRYPTO and use it in
> tests/Makefile too.

Except it was a goal of this work that we do not have such config
parameters leak outside to callers. The intent was that the APIs
are always built-in - we just conditionally disable the internal
implementation, so that code using these APIs does not need to
deal with conditionally disabling itself like this. It is
preferrable to just fix disablement of gnutls IMHO.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|