From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59398)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZJOL0-0002zU-0J
	for qemu-devel@nongnu.org; Sun, 26 Jul 2015 11:59:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZJOKz-0000Ip-0u
	for qemu-devel@nongnu.org; Sun, 26 Jul 2015 11:59:41 -0400
Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:38054)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZJOKy-0000If-R7
	for qemu-devel@nongnu.org; Sun, 26 Jul 2015 11:59:40 -0400
Date: Sun, 26 Jul 2015 17:59:37 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150726155937.GA28331@aurel32.net>
References: <1437780852-1549-1-git-send-email-aurelien@aurel32.net>
	<55B4084B.4060804@twiddle.net> <20150725225100.GA28706@aurel32.net>
	<55B417ED.2070506@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55B417ED.2070506@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs
 for mov with a constant
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On 2015-07-25 16:12, Richard Henderson wrote:
> On 07/25/2015 03:51 PM, Aurelien Jarno wrote:
> >On 2015-07-25 15:06, Richard Henderson wrote:
> >>On 07/24/2015 04:34 PM, Aurelien Jarno wrote:
> >>>          ots->val_type = TEMP_VAL_CONST;
> >>>          ots->val = ts->val;
> >>>+        if (IS_DEAD_ARG(1)) {
> >>>+            temp_dead(s, args[1]);
> >>>+        }
> >>
> >>Aren't we also missing
> >>
> >>   if (NEED_SYNC_ARG(0)) {
> >>     temp_sync(s, args[0], allocated_regs);
> >>   }
> >>
> >>along this path?
> >
> >I don't think so, I guess it's covered by the first part of this
> >function:
> >
> >|    if (((NEED_SYNC_ARG(0) || ots->fixed_reg) && ts->val_type != TEMP_VAL_REG)
> >|        || ts->val_type == TEMP_VAL_MEM) {
> >
> >It means after this block, a value that need to be synced will always
> >be in a register, including in the constant case.
> 
> Quite right.  Therefore,
> 
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> 
> Do you want to go ahead and push this for 2.4?

Yes, I think we should push it for 2.4. Do you want to do the pull
request or should I do it?

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net