From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZJSGK-0007at-FT
	for qemu-devel@nongnu.org; Sun, 26 Jul 2015 16:11:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZJSGJ-000443-HA
	for qemu-devel@nongnu.org; Sun, 26 Jul 2015 16:11:08 -0400
Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:39284)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZJSGJ-00042G-Al
	for qemu-devel@nongnu.org; Sun, 26 Jul 2015 16:11:07 -0400
Date: Sun, 26 Jul 2015 22:11:03 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150726201103.GA5432@aurel32.net>
References: <1437763343-7980-1-git-send-email-hpoussin@reactos.org>
	<1437763343-7980-2-git-send-email-hpoussin@reactos.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1437763343-7980-2-git-send-email-hpoussin@reactos.org>
Subject: Re: [Qemu-devel] [PATCH for 2.4 1/3] net/dp8393x: disable user
	creation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-15?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: Leon Alrae <leon.alrae@imgtec.com>, qemu-devel@nongnu.org

On 2015-07-24 20:42, Herv=E9 Poussineau wrote:
> Netcard needs an address space to write data to, which can't be specified=
 on command line.
> This fixes a crash when user starts QEMU with "-device dp8393x"
>=20
> Signed-off-by: Herv=E9 Poussineau <hpoussin@reactos.org>
> ---
>  hw/net/dp8393x.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
> index cd889bc..8fafdb0 100644
> --- a/hw/net/dp8393x.c
> +++ b/hw/net/dp8393x.c
> @@ -881,6 +881,8 @@ static void dp8393x_class_init(ObjectClass *klass, vo=
id *data)
>      dc->reset =3D dp8393x_reset;
>      dc->vmsd =3D &vmstate_dp8393x;
>      dc->props =3D dp8393x_properties;
> +    /* Reason: dma_mr property can't be set */
> +    dc->cannot_instantiate_with_device_add_yet =3D true;
>  }
> =20
>  static const TypeInfo dp8393x_info =3D {

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

--=20
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net