From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJefW-00069L-M0 for qemu-devel@nongnu.org; Mon, 27 Jul 2015 05:25:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJefT-0001fh-DL for qemu-devel@nongnu.org; Mon, 27 Jul 2015 05:25:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJefT-0001fV-82 for qemu-devel@nongnu.org; Mon, 27 Jul 2015 05:25:55 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id DC301367290 for ; Mon, 27 Jul 2015 09:25:54 +0000 (UTC) Date: Mon, 27 Jul 2015 11:25:49 +0200 From: Igor Mammedov Message-ID: <20150727112549.6490f6b8@nial.brq.redhat.com> In-Reply-To: <1437897651-9722-1-git-send-email-ghammer@redhat.com> References: <1437897651-9722-1-git-send-email-ghammer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] acpi: fix pvpanic device is not shown in ui List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Radim =?UTF-8?B?S3LEjW3DocWZ?= On Sun, 26 Jul 2015 11:00:51 +0300 Gal Hammer wrote: > Commit 2332333c added a _STA method that hides the device. The fact > that the device is not shown in the gui make it harder to install its > Windows' device. > > https://bugzilla.redhat.com/show_bug.cgi?id=1238141 > > Signed-off-by: Gal Hammer Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index aed811a..46eddb8 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1108,8 +1108,8 @@ build_ssdt(GArray *table_data, GArray *linker, > aml_append(field, aml_named_field("PEPT", 8)); > aml_append(dev, field); > > - /* device present, functioning, decoding, not shown in UI */ > - aml_append(dev, aml_name_decl("_STA", aml_int(0xB))); > + /* device present, functioning, decoding, shown in UI */ > + aml_append(dev, aml_name_decl("_STA", aml_int(0xF))); > > method = aml_method("RDPT", 0); > aml_append(method, aml_store(aml_name("PEPT"), aml_local(0)));