From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJgVT-0006Q0-Pu for qemu-devel@nongnu.org; Mon, 27 Jul 2015 07:23:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJgVR-0001QY-CV for qemu-devel@nongnu.org; Mon, 27 Jul 2015 07:23:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJgVR-0001QR-7i for qemu-devel@nongnu.org; Mon, 27 Jul 2015 07:23:41 -0400 Date: Mon, 27 Jul 2015 14:23:37 +0300 From: "Michael S. Tsirkin" Message-ID: <20150727142314-mutt-send-email-mst@redhat.com> References: <1437990561-22134-1-git-send-email-jasowang@redhat.com> <1437990561-22134-3-git-send-email-jasowang@redhat.com> <55B607C7.9070705@redhat.com> <20150727123944.206dc063.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150727123944.206dc063.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH V4 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Paolo Bonzini , Jason Wang , qemu-devel@nongnu.org On Mon, Jul 27, 2015 at 12:39:44PM +0200, Cornelia Huck wrote: > On Mon, 27 Jul 2015 12:28:23 +0200 > Paolo Bonzini wrote: > > > On 27/07/2015 11:49, Jason Wang wrote: > > > + if (__virtio_has_feature(features, VIRTIO_F_VERSION_1)) { > > > > No double underscores in userspace code. Longstanding so it can be > > fixed after 2.4 is out---but please remember to do it. > > There's https://marc.info/?l=qemu-devel&m=142599436726514&w=2 > which seems to have been lost in all that virtio rebasing. Right. Pls repost after 2.4. -- MST