From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJkJh-0006VW-2j for qemu-devel@nongnu.org; Mon, 27 Jul 2015 11:27:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJkJf-0007ZT-Qf for qemu-devel@nongnu.org; Mon, 27 Jul 2015 11:27:49 -0400 Date: Mon, 27 Jul 2015 18:27:34 +0300 From: "Michael S. Tsirkin" Message-ID: <20150727182239-mutt-send-email-mst@redhat.com> References: <1437990561-22134-1-git-send-email-jasowang@redhat.com> <1437990561-22134-4-git-send-email-jasowang@redhat.com> <55B6083B.5060603@redhat.com> <20150727142207-mutt-send-email-mst@redhat.com> <20150727152851.2c0d8aad.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150727152851.2c0d8aad.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH V4 3/3] virtio-blk: only clear VIRTIO_F_ANY_LAYOUT for legacy device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Kevin Wolf , qemu-block@nongnu.org, Jason Wang , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini On Mon, Jul 27, 2015 at 03:28:51PM +0200, Cornelia Huck wrote: > On Mon, 27 Jul 2015 14:22:37 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jul 27, 2015 at 12:30:19PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 27/07/2015 11:49, Jason Wang wrote: > > > > So this patch only clear VIRTIO_F_LAYOUT for legacy device. > > > > > > > > Cc: Stefan Hajnoczi > > > > Cc: Kevin Wolf > > > > Cc: qemu-block@nongnu.org > > > > Signed-off-by: Jason Wang > > > > --- > > > > hw/block/virtio-blk.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > > > > index 9acbc3a..1d3f26c 100644 > > > > --- a/hw/block/virtio-blk.c > > > > +++ b/hw/block/virtio-blk.c > > > > @@ -731,7 +731,6 @@ static uint64_t virtio_blk_get_features(VirtIODevice *vdev, uint64_t features, > > > > virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY); > > > > virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY); > > > > virtio_add_feature(&features, VIRTIO_BLK_F_BLK_SIZE); > > > > - virtio_clear_feature(&features, VIRTIO_F_ANY_LAYOUT); > > > > if (__virtio_has_feature(features, VIRTIO_F_VERSION_1)) { > > > > if (s->conf.scsi) { > > > > error_setg(errp, "Virtio 1.0 does not support scsi passthrough!"); > > > > @@ -739,6 +738,7 @@ static uint64_t virtio_blk_get_features(VirtIODevice *vdev, uint64_t features, > > > > } > > > > virtio_add_feature(&features, VIRTIO_F_ANY_LAYOUT); > > > > } else { > > > > + virtio_clear_feature(&features, VIRTIO_F_ANY_LAYOUT); > > > > virtio_add_feature(&features, VIRTIO_BLK_F_SCSI); > > > > } > > > > > > This patch is unnecessary, since the feature is added back below under > > > "if (__virtio_has_feature(features, VIRTIO_F_VERSION_1))". > > > > > > Paolo > > > > It's needed so we can apply > > virtio: set any_layout in virtio core > > So what's the plan on all those virtio feature patches? It's hard to > keep track about what is based upon what, and what the end result looks > like. I pushed everything out to my pci branch, pls take a look. This is what I have: b787b35 acpi: fix pvpanic device is not shown in ui 49009db hw/acpi/ich9: clean up stale comment about KVM not supporting SMM e513e9c hw/acpi/ich9: clear smi_en on reset c9b11f9 virtio-blk: only clear VIRTIO_F_ANY_LAYOUT for legacy device efb8206 virtio-blk: fail get_features when both scsi and 1.0 were set 9d5b731 virtio: get_features() can fail 2746269 virtio-pci: fix memory MR cleanup for modern 09999a5 virtio: set any_layout in virtio core cd4bfbb virtio-9p: fix any_layout 7882080 virtio-serial: fix ANY_LAYOUT 5f45607 virtio: hide legacy features from modern guests > I don't have a good feeling about doing this that late in the 2.4 > cycle. Well there will always be bugs. Given modern is disabled by default, even if more bugs surface after release it's not the end of the world. -- MST