From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZJwDP-0003mS-Bo
	for qemu-devel@nongnu.org; Tue, 28 Jul 2015 00:10:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZJwDK-0007g5-9H
	for qemu-devel@nongnu.org; Tue, 28 Jul 2015 00:10:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZJwDK-0007et-4X
	for qemu-devel@nongnu.org; Tue, 28 Jul 2015 00:10:02 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id 94AFC347DAF
	for <qemu-devel@nongnu.org>; Tue, 28 Jul 2015 04:10:01 +0000 (UTC)
Date: Tue, 28 Jul 2015 12:09:59 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150728040959.GA1865@ad.nay.redhat.com>
References: <1437998061-22771-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1437998061-22771-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-nbd: remove unnecessary
 qemu_notify_event()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 07/27 13:54, Paolo Bonzini wrote:
> This was needed when qemu-nbd was using qemu_set_fd_handler2.  It is
> not needed anymore now that nbd_update_server_fd_handler is called
> whenever nbd_can_accept() can change from false to true.
> nbd_update_server_fd_handler will call qemu_set_fd_handler(),
> which will call qemu_notify_event().
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qemu-nbd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index 5106b80..d9644b2 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -362,7 +362,6 @@ static void nbd_client_closed(NBDClient *client)
>          state = TERMINATE;
>      }
>      nbd_update_server_fd_handler(server_fd);
> -    qemu_notify_event();
>      nbd_client_put(client);
>  }
>  
> -- 
> 2.4.3
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>

A question not related to this patch: unlike aio_set_fd_handler,
qemu_set_fd_handler doesn't call qemu_notify_event for the "delete" branch. Is
that intended?