qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: borntraeger@de.ibm.com, qemu-devel@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.4 0/2] AioContext: fix deadlock after aio_context_acquire() race
Date: Tue, 28 Jul 2015 10:02:26 +0200	[thread overview]
Message-ID: <20150728100226.49bafc67.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20150728090700.73f001d3.cornelia.huck@de.ibm.com>

On Tue, 28 Jul 2015 09:07:00 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:

> On Mon, 27 Jul 2015 17:33:37 +0100
> Stefan Hajnoczi <stefanha@redhat.com> wrote:
> 
> > See Patch 2 for details on the deadlock after two aio_context_acquire() calls
> > race.  This caused dataplane to hang on startup.
> > 
> > Patch 1 is a memory leak fix for AioContext that's needed by Patch 2.
> > 
> > Stefan Hajnoczi (2):
> >   AioContext: avoid leaking BHs on cleanup
> >   AioContext: force event loop iteration using BH
> > 
> >  async.c             | 29 +++++++++++++++++++++++++++--
> >  include/block/aio.h |  3 +++
> >  2 files changed, 30 insertions(+), 2 deletions(-)
> > 
> 
> Just gave this a try: The stripped-down guest that hangs during startup
> on master is working fine with these patches applied, and my full setup
> works as well.
> 
> So,
> 
> Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>

Uh-oh, spoke too soon. It starts, but when I try a virsh managedsave, I
get

qemu-system-s390x: /data/git/yyy/qemu/async.c:242: aio_ctx_finalize: Assertion `ctx->first_bh->deleted' failed.

  reply	other threads:[~2015-07-28  8:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 16:33 [Qemu-devel] [PATCH for-2.4 0/2] AioContext: fix deadlock after aio_context_acquire() race Stefan Hajnoczi
2015-07-27 16:33 ` [Qemu-devel] [PATCH for-2.4 1/2] AioContext: avoid leaking BHs on cleanup Stefan Hajnoczi
2015-07-27 16:33 ` [Qemu-devel] [PATCH for-2.4 2/2] AioContext: force event loop iteration using BH Stefan Hajnoczi
2015-07-27 17:49   ` Paolo Bonzini
2015-07-28  7:07 ` [Qemu-devel] [PATCH for-2.4 0/2] AioContext: fix deadlock after aio_context_acquire() race Cornelia Huck
2015-07-28  8:02   ` Cornelia Huck [this message]
2015-07-28  8:34     ` Stefan Hajnoczi
2015-07-28 10:26       ` Cornelia Huck
2015-07-28 10:31         ` Stefan Hajnoczi
2015-07-28 10:34           ` Stefan Hajnoczi
2015-07-28 10:58             ` Cornelia Huck
2015-07-28 12:18               ` Paolo Bonzini
2015-07-28 13:58                 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150728100226.49bafc67.cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).