From: Stefan Hajnoczi <stefanha@gmail.com>
To: Greg Ungerer <gerg@uclinux.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/net: handle flow control in mcf_fec driver receiver
Date: Tue, 28 Jul 2015 11:29:08 +0100 [thread overview]
Message-ID: <20150728102908.GG32719@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1438045374-10358-1-git-send-email-gerg@uclinux.org>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
On Tue, Jul 28, 2015 at 11:02:54AM +1000, Greg Ungerer wrote:
> The network mcf_fec driver emulated receive side method is not dealing
> with network queue flow control properly.
>
> Modify the receive side to check if we have enough space in the
> descriptors to store the current packet. If not we process none of it
> and return 0. When the guest frees up some buffers through its descriptors
> we signal the qemu net layer to send more packets.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
> ---
> hw/net/mcf_fec.c | 45 ++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 34 insertions(+), 11 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-07-28 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 1:02 [Qemu-devel] [PATCH] hw/net: handle flow control in mcf_fec driver receiver Greg Ungerer
2015-07-28 10:29 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728102908.GG32719@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=gerg@uclinux.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).