From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK28L-00089I-Gu for qemu-devel@nongnu.org; Tue, 28 Jul 2015 06:29:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK28G-00048K-8b for qemu-devel@nongnu.org; Tue, 28 Jul 2015 06:29:17 -0400 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:34940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK28G-00047r-1n for qemu-devel@nongnu.org; Tue, 28 Jul 2015 06:29:12 -0400 Received: by wibxm9 with SMTP id xm9so150369142wib.0 for ; Tue, 28 Jul 2015 03:29:11 -0700 (PDT) Date: Tue, 28 Jul 2015 11:29:08 +0100 From: Stefan Hajnoczi Message-ID: <20150728102908.GG32719@stefanha-thinkpad.redhat.com> References: <1438045374-10358-1-git-send-email-gerg@uclinux.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f5QefDQHtn8hx44O" Content-Disposition: inline In-Reply-To: <1438045374-10358-1-git-send-email-gerg@uclinux.org> Subject: Re: [Qemu-devel] [PATCH] hw/net: handle flow control in mcf_fec driver receiver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Ungerer Cc: qemu-devel@nongnu.org --f5QefDQHtn8hx44O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 28, 2015 at 11:02:54AM +1000, Greg Ungerer wrote: > The network mcf_fec driver emulated receive side method is not dealing > with network queue flow control properly. >=20 > Modify the receive side to check if we have enough space in the > descriptors to store the current packet. If not we process none of it > and return 0. When the guest frees up some buffers through its descriptors > we signal the qemu net layer to send more packets. >=20 > Signed-off-by: Greg Ungerer > --- > hw/net/mcf_fec.c | 45 ++++++++++++++++++++++++++++++++++----------- > 1 file changed, 34 insertions(+), 11 deletions(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan --f5QefDQHtn8hx44O Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVt1l0AAoJEJykq7OBq3PIzMoH/2jIt73VswOA7mBqqUB+gIKd WBiQOLKm7u7VntEDTSzlKzRz1+j0NciUuKGvL0WlkrOT7lr5rnX0ri7j2uHkKnXg 5O8QHZvCZMTVFjMQAmPcJmpYlSHKT7MlAeafgGYaDIzybclEr782EYGZJe8cjpky TSgDcMWlf7+tlHHIfgnGgd6J6y4JC/hQ+lq72xcf8Dk2BIMdOicW7BtPDD28Zljk PrGA1zhCLkjHTnp/akiw1LB/3x/5OWo8dR/62CKmO+vmQA8Ns13u4GIT2IKQF9fz Bq+EkpdmM2s7PYd8xai2e0LLAz+D7e4d10lvASx886DDe9exVdCpKjW1hAZJBFQ= =Qcy2 -----END PGP SIGNATURE----- --f5QefDQHtn8hx44O--