From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK2F2-00055X-3E for qemu-devel@nongnu.org; Tue, 28 Jul 2015 06:36:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK2Ex-00027M-Bi for qemu-devel@nongnu.org; Tue, 28 Jul 2015 06:36:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK2Ex-00026x-6u for qemu-devel@nongnu.org; Tue, 28 Jul 2015 06:36:07 -0400 Date: Tue, 28 Jul 2015 11:36:05 +0100 From: Stefan Hajnoczi Message-ID: <20150728103605.GA7899@stefanha-thinkpad.redhat.com> References: <1438077176-378-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9amGYk9869ThD9tj" Content-Disposition: inline In-Reply-To: <1438077176-378-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.4 v3] xen: Drop net_rx_ok List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: jasowang@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, Chen Gang --9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 28, 2015 at 05:52:56PM +0800, Fam Zheng wrote: > Let net_rx_packet() (which checks the same conditions) drops the packet > if the device is not ready. Drop net_xen_info.can_receive and update the > return value for the buffer full case. >=20 > We rely on the qemu_flush_queued_packets() in net_event() to wake up > the peer when the buffer becomes available again. >=20 > Signed-off-by: Fam Zheng >=20 > --- >=20 > v3: Drop log. [Wen] >=20 > v2: > Fix return value of net_rx_packet to keep the semantics when ring > buffer is full. [Stefan] > Update commit message accordingly. > --- > hw/net/xen_nic.c | 25 +------------------------ > 1 file changed, 1 insertion(+), 24 deletions(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan --9amGYk9869ThD9tj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVt1sVAAoJEJykq7OBq3PIhs0IALR66vvPdtTefIPDVCs1xpNt hsCbYdBX0P9KugiD+/e3i0q817b1T+JoppwMf7tp6Gf1YoOQVFiM9+ala1kWRuGp oHIQHgjDLru2YfyJoMnjHiPSCrFf5SL8QhrZ/Cv/+FI83LnIXPQQIhQmVs9318mW to3nUlqe+33f4NsVZxlcmS22q6fuJWQ64bkC0Ng83TJlU1DV0b8nV811a/8+Fn2l McqhdwLGGRbmHUyZDnINLj8Z5r+RVqLux5lpk0WQgPVFjHr5qw6II1eP/Oc8rsoO mSWAo/2ISij0nt1a3BqVMJ1Qhm1586beRlqZurwkCymhRVtuDhMkALnn3j0xb0c= =EMe4 -----END PGP SIGNATURE----- --9amGYk9869ThD9tj--