From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: jasowang@redhat.com, stefano.stabellini@eu.citrix.com,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [Qemu-devel] [PATCH for-2.4 v3] xen: Drop net_rx_ok
Date: Tue, 28 Jul 2015 13:27:43 +0100 [thread overview]
Message-ID: <20150728122743.GH32719@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1438077176-378-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Tue, Jul 28, 2015 at 05:52:56PM +0800, Fam Zheng wrote:
> Let net_rx_packet() (which checks the same conditions) drops the packet
> if the device is not ready. Drop net_xen_info.can_receive and update the
> return value for the buffer full case.
>
> We rely on the qemu_flush_queued_packets() in net_event() to wake up
> the peer when the buffer becomes available again.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
>
> v3: Drop log. [Wen]
>
> v2:
> Fix return value of net_rx_packet to keep the semantics when ring
> buffer is full. [Stefan]
> Update commit message accordingly.
> ---
> hw/net/xen_nic.c | 25 +------------------------
> 1 file changed, 1 insertion(+), 24 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-07-28 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 9:52 [Qemu-devel] [PATCH for-2.4 v3] xen: Drop net_rx_ok Fam Zheng
2015-07-28 10:36 ` Stefan Hajnoczi
2015-07-28 12:27 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728122743.GH32719@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).