From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK3z4-00088c-0t for qemu-devel@nongnu.org; Tue, 28 Jul 2015 08:27:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK3z0-0005jv-KO for qemu-devel@nongnu.org; Tue, 28 Jul 2015 08:27:49 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:36223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK3z0-0005jf-EM for qemu-devel@nongnu.org; Tue, 28 Jul 2015 08:27:46 -0400 Received: by wicgb10 with SMTP id gb10so154308467wic.1 for ; Tue, 28 Jul 2015 05:27:45 -0700 (PDT) Date: Tue, 28 Jul 2015 13:27:43 +0100 From: Stefan Hajnoczi Message-ID: <20150728122743.GH32719@stefanha-thinkpad.redhat.com> References: <1438077176-378-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="h3LYUU6HlUDSAOzy" Content-Disposition: inline In-Reply-To: <1438077176-378-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.4 v3] xen: Drop net_rx_ok List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: jasowang@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, Stefan Hajnoczi , Chen Gang --h3LYUU6HlUDSAOzy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 28, 2015 at 05:52:56PM +0800, Fam Zheng wrote: > Let net_rx_packet() (which checks the same conditions) drops the packet > if the device is not ready. Drop net_xen_info.can_receive and update the > return value for the buffer full case. >=20 > We rely on the qemu_flush_queued_packets() in net_event() to wake up > the peer when the buffer becomes available again. >=20 > Signed-off-by: Fam Zheng >=20 > --- >=20 > v3: Drop log. [Wen] >=20 > v2: > Fix return value of net_rx_packet to keep the semantics when ring > buffer is full. [Stefan] > Update commit message accordingly. > --- > hw/net/xen_nic.c | 25 +------------------------ > 1 file changed, 1 insertion(+), 24 deletions(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan --h3LYUU6HlUDSAOzy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVt3U/AAoJEJykq7OBq3PIV1wIAJQ+IrgpNYFjIjJvm1tP8umF XL6bOlEG3WWMgiD/djNZ2XHSEOLPLMTzjRsl9dpJjhguR+QNy7ZFW2qU4DP1Gp7g 1xWtd7Nkp6qcO1n7p61U1eal8jhWvIg5ixJMsGNFtx8nUn1aEM5HuydoP3uZbise iKTG5Cc8TnLoWibYQbdD+JxNngp7Gkhx3FGDsObMG9MdzwI9BkIPIyWLb53sawEr qBZPDRX+5P0cQXt+wWUjxuWeY6BjJXuZd3xn0i/IAvi2DzaLP9I+8Tw2CTd/4zKz 08Oosjo9XMr079XRZD+c/t49VTj0hdbk2NLBHF5G0J5P6YSYExrpoBOrIldh9FY= =uyfH -----END PGP SIGNATURE----- --h3LYUU6HlUDSAOzy--