From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKMwj-00070k-EP for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:42:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKMwf-0003XO-Vd for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:42:41 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:38855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKMwf-0003Wz-I0 for qemu-devel@nongnu.org; Wed, 29 Jul 2015 04:42:37 -0400 Received: by wibxm9 with SMTP id xm9so15691857wib.1 for ; Wed, 29 Jul 2015 01:42:36 -0700 (PDT) Date: Wed, 29 Jul 2015 09:42:33 +0100 From: Stefan Hajnoczi Message-ID: <20150729084233.GA10617@stefanha-thinkpad.redhat.com> References: <1437997292-21715-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <1437997292-21715-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] fixup! virtio-blk: fail get_features when both scsi and 1.0 were set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: cornelia.huck@de.ibm.com, Jason Wang , qemu-devel@nongnu.org, mst@redhat.com --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 27, 2015 at 01:41:32PM +0200, Paolo Bonzini wrote: > Tweak the error message so that it does not mention SCSI passthrough. Th= at > can be confusing because you can have scsi=3Don even for file-backed imag= e, > which obviously do not support SCSI passthrough at the block layer level. >=20 > Signed-off-by: Paolo Bonzini > --- > hw/block/virtio-blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index 9acbc3a..7bed3f0 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -734,7 +734,7 @@ static uint64_t virtio_blk_get_features(VirtIODevice = *vdev, uint64_t features, > virtio_clear_feature(&features, VIRTIO_F_ANY_LAYOUT); > if (__virtio_has_feature(features, VIRTIO_F_VERSION_1)) { > if (s->conf.scsi) { > - error_setg(errp, "Virtio 1.0 does not support scsi passthrou= gh!"); > + error_setg(errp, "Please set scsi=3Doff for virtio-blk devic= es in order to use virtio 1.0"); > return 0; > } > virtio_add_feature(&features, VIRTIO_F_ANY_LAYOUT); For the record, this patch has been merged as part of: commit efb8206ca7f19f5a6ece1f2851a73a29de309b1e Author: Jason Wang Date: Mon Jul 27 17:49:20 2015 +0800 virtio-blk: fail get_features when both scsi and 1.0 were set --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVuJH5AAoJEJykq7OBq3PIpIEIAJKkNC97dOExT/kjs2hic206 MkvjhYQQbnYi3U7ox22yX0BUDI+QMTEQu9gn6k/O5MC4CEGg0o+AO8e2q43YR6fg kbqzTQ79S/GAEESD3ir9rd9NSZwWhWzUk1oloy9stvgchr0XIxC3x4ecIDc6q68Z KAdN0kGmJB2GnFSnrdpddWYbROwp3MdPZcA8bX0MGef9mRRf0eriDHFSpiiXSSEy 9HF+25iH3PYavnsL4WltMim0Ba+aZmFPtpcShbk/srUXMeHIcc0XFle73y0uDdhL 9xnkDKswfYK/xqR9E9gVVHX9Ne9XXPK8ySUu0gSG63xEDXbVp8hdl6FtIufFawo= =qbgd -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--