From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKNna-0004gS-Gh for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:37:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKNnX-0007zp-JE for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:37:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKNnX-0007zl-Ev for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:37:15 -0400 Date: Wed, 29 Jul 2015 10:37:09 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150729093708.GE2267@work-vm> References: <1438159544-6224-1-git-send-email-zhang.zhanghailiang@huawei.com> <1438159544-6224-24-git-send-email-zhang.zhanghailiang@huawei.com> <55B8958D.8000809@redhat.com> <20150729091900.GC16847@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150729091900.GC16847@redhat.com> Subject: Re: [Qemu-devel] [PATCH COLO-Frame v8 23/34] tap: Make launch_script() public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: lizhijian@cn.fujitsu.com, zhanghailiang , quintela@redhat.com, Jason Wang , yunhong.jiang@intel.com, eddie.dong@intel.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, arei.gonglei@huawei.com, Stefan Hajnoczi , amit.shah@redhat.com * Daniel P. Berrange (berrange@redhat.com) wrote: > On Wed, Jul 29, 2015 at 04:57:49PM +0800, Jason Wang wrote: > > > > > > On 07/29/2015 04:45 PM, zhanghailiang wrote: > > > We also change the parameters of launch_script(). > > > > A quick question (I don't go through the codes tough). What's the plan > > for management(libvirt)? I believe some setup (iptables, fd creation) > > should be offloaded to management (libvirt)? > > Yep, libvirt will run QEMU unprivileged, so this effectively blocks any > use of QEMU executed scripts for managing host network setup, making > this launch_script facility effectively useless. Not useless; it's very useful to those getting it going without libvirt. Obviously it won't get used when libvirt is setup with it, but that's a separate step. Dave > > Regards, > Daniel > -- > |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| > |: http://libvirt.org -o- http://virt-manager.org :| > |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| > |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK