From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1ZKNOC-0002cL-79
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:11:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1ZKNO7-0002rF-Pd
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:11:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44571)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1ZKNO7-0002qy-JU
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 05:10:59 -0400
Date: Wed, 29 Jul 2015 11:10:55 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20150729111055.2bf307ac@nial.brq.redhat.com>
In-Reply-To: <015a01d0c85c$b52b61d0$1f822570$@samsung.com>
References: <015a01d0c85c$b52b61d0$1f822570$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: 'Peter Maydell' <peter.maydell@linaro.org>, pbonzini@redhat.com, 'QEMU Developers' <qemu-devel@nongnu.org>, 'Alexander Graf' <agraf@suse.de>

On Mon, 27 Jul 2015 14:09:28 +0300
Pavel Fedin <p.fedin@samsung.com> wrote:

> @@ -234,6 +236,12 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap, int irq)
>                       AML_ENTIRE_RANGE, 0x0000, 0x0000, size_pio - 1, base_pio,
>                       size_pio));
>  
> +    aml_append(rbuf,
> +        aml_dword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MAX_FIXED,
this is wrong since dword is too small for values of high memory
use aml_qword_memory() instead

> +                         AML_NON_CACHEABLE, AML_READ_WRITE, 0x0000,
> +                         base_mmio_high, base_mmio_high + size_mmio_high - 1,
since window is at fixed position and it's not possible for guest to
move base address of the range, make AddressMaximum the same as AddressMinimum i.e.

  s/base_mmio_high + size_mmio_high - 1/base_mmio_high/

> +                         0x0000, size_mmio_high));