Re: [Qemu-devel] [PATCH for-2.5] virtio: avoid leading underscores for helpers

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Wed, 29 Jul 2015 08:43:08 -0400 (EDT)
Thomas Huth <thuth@redhat.com> wrote:

> On Wednesday, July 29, 2015 2:22:47 PM, "Cornelia Huck"
> <cornelia.huck@de.ibm.com> wrote:
> > 
> > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add
> > feature checking helpers") introduced a helper __virtio_has_feature.
> > We don't want to use reserved identifiers, though, so let's
> > rename __virtio_has_feature to virtio_has_feature and virtio_has_feature
> > to virtio_vdev_has_feature.
> 
> "virtio_vdev_has_feature" is already a little bit long ... but I also fail
> come up with a better name, maybe "virtio_vdev_has_feat" ?

Yeah, I also failed to come up with a shorter name that still conveys
the relationship with virtio_has_feature...

> 
> Anyway, the patch also looks fine to me with the long name, so:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 

Thanks!