From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL9SK-00039o-KA for qemu-devel@nongnu.org; Fri, 31 Jul 2015 08:30:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZL9SD-0005Xj-TD for qemu-devel@nongnu.org; Fri, 31 Jul 2015 08:30:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL9SD-0005XE-PE for qemu-devel@nongnu.org; Fri, 31 Jul 2015 08:30:25 -0400 Date: Fri, 31 Jul 2015 13:30:21 +0100 From: "Daniel P. Berrange" Message-ID: <20150731123021.GH2392@redhat.com> References: <20150731120643.GF2392@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] RFC: use of qemu-common.h include Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Fri, Jul 31, 2015 at 01:19:11PM +0100, Peter Maydell wrote: > On 31 July 2015 at 13:06, Daniel P. Berrange wrote: > > In fixing the mingw64 problem wrt to localtime_r availability, I relied > > on the fact that qemu-common.h is supposed to be included everywhere, > > to guarantee that we always have unistd.h included before time.h: > > It's not really supposed to be included everywhere. It's just a > convenient way for a .c file to get a lot of stuff all at once. > It's a bit of a mess. > > > So I'm wondering if there is appetite for cleaning this and and > > introducing standard practice for inclusion of qemu-common.h ? > > You might want to have a look at my series which tries to > make osdep.h the "anybody can include this to get the really > key 'breaks if this isn't here' stuff". > > http://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg04593.html Ah, interesting, I'll check out that series - it sounds like it is similar to what i was thinking Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|