From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL9ha-0008Uz-3j for qemu-devel@nongnu.org; Fri, 31 Jul 2015 08:46:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZL9hW-0005vb-UO for qemu-devel@nongnu.org; Fri, 31 Jul 2015 08:46:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZL9hW-0005vV-PX for qemu-devel@nongnu.org; Fri, 31 Jul 2015 08:46:14 -0400 Date: Fri, 31 Jul 2015 13:46:10 +0100 From: "Daniel P. Berrange" Message-ID: <20150731124610.GI2392@redhat.com> References: <1437583451-9677-1-git-send-email-peter.maydell@linaro.org> <1437583451-9677-2-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1437583451-9677-2-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH 01/12] qapi/qmp-event.c: Don't manually include os-win32.h/os-posix.h Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On Wed, Jul 22, 2015 at 05:44:00PM +0100, Peter Maydell wrote: > qmp-event.c already includes qemu-common.h, so manually including > os-win32.h/os-posix.h is unnecessary (and potentially fragile, > since it's duplicating the #ifdef logic that chooses which of the > two we need). Remove the unnecessary include logic. > > Signed-off-by: Peter Maydell > --- > qapi/qmp-event.c | 8 -------- > 1 file changed, 8 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|