From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLE8b-0005jT-RT for qemu-devel@nongnu.org; Fri, 31 Jul 2015 13:30:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZLE8W-0005pK-3D for qemu-devel@nongnu.org; Fri, 31 Jul 2015 13:30:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLE8V-0005oP-UO for qemu-devel@nongnu.org; Fri, 31 Jul 2015 13:30:24 -0400 Date: Fri, 31 Jul 2015 18:30:20 +0100 From: "Daniel P. Berrange" Message-ID: <20150731173020.GT2392@redhat.com> References: <1437583451-9677-1-git-send-email-peter.maydell@linaro.org> <20150731125409.GO2392@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 00/12] qemu-common.h/osdep.h refactoring Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Patch Tracking On Fri, Jul 31, 2015 at 01:57:29PM +0100, Peter Maydell wrote: > On 31 July 2015 at 13:54, Daniel P. Berrange wrote: > > I broadly like the direction of this change. I think it is > > probably worth being strict about requiring #include of > > osdep.h as the first header in every .c file. And validating > > such a rule programmatically at make check time or equiv. > > Yeah, I think that validating that automatically would be cool. FYI I just copied you on a series that shows one way we can achieve that https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg06268.html Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|