From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60088)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZLEAy-0008CM-N1
	for qemu-devel@nongnu.org; Fri, 31 Jul 2015 13:33:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZLEAp-0007BT-F9
	for qemu-devel@nongnu.org; Fri, 31 Jul 2015 13:32:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50567)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZLEAp-0007Aq-AS
	for qemu-devel@nongnu.org; Fri, 31 Jul 2015 13:32:47 -0400
Date: Fri, 31 Jul 2015 18:32:43 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150731173243.GV2392@redhat.com>
References: <1437583451-9677-1-git-send-email-peter.maydell@linaro.org>
	<1437583451-9677-9-git-send-email-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1437583451-9677-9-git-send-email-peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 08/12] qemu-common.h: Move muldiv64() to
 host-utils.h
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org

On Wed, Jul 22, 2015 at 05:44:07PM +0100, Peter Maydell wrote:
> Move the muldiv64() function from qemu-common.h to host-utils.h.
> This puts it together with all the other arithmetic functions
> where we provide a version with __int128_t and a fallback
> without, and allows headers which need muldiv64() to avoid
> including qemu-common.h.
> 
> We don't include host-utils from qemu-common.h, to avoid dragging
> more things into qemu-common.h than it already has; in practice
> everywhere that needs muldiv64() can get it via qemu/timer.h.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  include/qemu-common.h     | 31 -------------------------------
>  include/qemu/host-utils.h | 29 +++++++++++++++++++++++++++++
>  include/qemu/timer.h      |  1 +
>  3 files changed, 30 insertions(+), 31 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|