From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMBEA-0005nJ-Os for qemu-devel@nongnu.org; Mon, 03 Aug 2015 04:36:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMBE7-0000kL-Bq for qemu-devel@nongnu.org; Mon, 03 Aug 2015 04:36:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMBE7-0000iv-74 for qemu-devel@nongnu.org; Mon, 03 Aug 2015 04:36:07 -0400 Date: Mon, 3 Aug 2015 09:36:00 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150803083600.GA2362@work-vm> References: <1438098885-4339-1-git-send-email-anthony.perard@citrix.com> <20150729175416.GN1379@perard.uk.xensource.com> <87d1z9q4zu.fsf@neno.neno> <20150803054402.GA28564@grmbl.mre> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150803054402.GA28564@grmbl.mre> Subject: Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Juan Quintela , Stefano Stabellini , QEMU-devel , Xen Devel , Stefano Stabellini , Anthony PERARD * Amit Shah (amit.shah@redhat.com) wrote: > On (Fri) 31 Jul 2015 [10:59:47], Stefano Stabellini wrote: > > On Thu, 30 Jul 2015, Stefano Stabellini wrote: > > > On Thu, 30 Jul 2015, Juan Quintela wrote: > > > > Anthony PERARD wrote: > > > > > This is a critical issue for Xen as migration either with the same version > > > > > of QEMU, or from a previous version of QEMU is broken. > > > > > > > > > > Any suggestion on how to move forward? > > > > > > > > Will send a pull requset tomorrow. > > > > > > > > Thinking about creating a single function that is called for all needed > > > > places, just to avoid this problem in the future. > > > > > > > > > > Hi Juan, > > > > > > thanks for looking into this! > > > Do you have patches already we can look at and help you test to make > > > sure they fix the issue? > > > > Any updates? > > That bigger overhaul would be 2.5 stuff now. > > The only thing that tripped here was the RFC tag in the subject line. > > Also, I think Dave had a comment about this but I think that was made > on IRC. Dave, do you see a problem with this series? Most of it is in Xen only code, so mostly no, however, the followign code looks wrong to me: +void global_state_store_running(void) +{ + const char *state = RunState_lookup[RUN_STATE_RUNNING]; + memcpy((char *)global_state.runstate, + state, sizeof(global_state.runstate)); +} Shouldn't that just be a strcpy ? Dave > Thanks, > > > Amit -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK