From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32982)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1ZMF34-0008V2-0h
	for qemu-devel@nongnu.org; Mon, 03 Aug 2015 08:40:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1ZMF33-0006OA-7s
	for qemu-devel@nongnu.org; Mon, 03 Aug 2015 08:40:57 -0400
Date: Mon, 3 Aug 2015 08:40:49 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20150803124049.GA9878@localhost.localdomain>
References: <1438595557-28144-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438595557-28144-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] sheepdog: remove back pointer to
	BlockDriverState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Mon, Aug 03, 2015 at 11:52:37AM +0200, Paolo Bonzini wrote:
> Since sheepdog does not implement a rebind callback, this back pointer
> is dangerous.  Do not use it.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/sheepdog.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 9585beb..68f1a0d 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -346,7 +346,6 @@ struct SheepdogAIOCB {
>  };
>  
>  typedef struct BDRVSheepdogState {
> -    BlockDriverState *bs;
>      AioContext *aio_context;
>  
>      SheepdogInode inode;
> @@ -738,7 +737,7 @@ static coroutine_fn void reconnect_to_sdog(void *opaque)
>          if (s->fd < 0) {
>              DPRINTF("Wait for connection to be established\n");
>              error_report_err(local_err);
> -            co_aio_sleep_ns(bdrv_get_aio_context(s->bs), QEMU_CLOCK_REALTIME,
> +            co_aio_sleep_ns(s->aio_context, QEMU_CLOCK_REALTIME,
>                              1000000000ULL);
>          }
>      };
> @@ -1392,7 +1391,6 @@ static int sd_open(BlockDriverState *bs, QDict *options, int flags,
>      Error *local_err = NULL;
>      const char *filename;
>  
> -    s->bs = bs;
>      s->aio_context = bdrv_get_aio_context(bs);
>  
>      opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort);
> -- 
> 2.4.3
>

Is this intended for 2.4?