From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36617)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=650b28316=anthony.perard@citrix.com>)
	id 1ZMH79-0000AN-Hj
	for qemu-devel@nongnu.org; Mon, 03 Aug 2015 10:53:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=650b28316=anthony.perard@citrix.com>)
	id 1ZMH76-0001ai-SA
	for qemu-devel@nongnu.org; Mon, 03 Aug 2015 10:53:19 -0400
Received: from smtp.citrix.com ([66.165.176.89]:63502)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=650b28316=anthony.perard@citrix.com>)
	id 1ZMH76-0001aQ-NU
	for qemu-devel@nongnu.org; Mon, 03 Aug 2015 10:53:16 -0400
Date: Mon, 3 Aug 2015 15:53:09 +0100
From: Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <20150803145309.GA1394@perard.uk.xensource.com>
References: <1438612161-15822-1-git-send-email-anthony.perard@citrix.com>
	<1438612161-15822-3-git-send-email-anthony.perard@citrix.com>
	<alpine.DEB.2.02.1508031547280.11337@kaball.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1508031547280.11337@kaball.uk.xensource.com>
Subject: Re: [Qemu-devel] [PATCH for-2.4 v3 2/3] migration: Add
 configuration section to vmstate with xen.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Amit Shah <amit.shah@redhat.com>, Juan Quintela <quintela@redhat.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, QEMU-devel <qemu-devel@nongnu.org>, Xen Devel <xen-devel@lists.xen.org>

On Mon, Aug 03, 2015 at 03:48:18PM +0100, Stefano Stabellini wrote:
> On Mon, 3 Aug 2015, Anthony PERARD wrote:
> > This adds the configuration section in the vmstate saved by
> > xen_save_devices_state.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> It doesn't seem to me that this patch is actually necessary to fix the
> issue, is that right? 

No, it is not. This is going to be skipped with the next patch and with
accel=xen.

> If that is the case, I would rather skip it.
> 
> 
> >  migration/savevm.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/migration/savevm.c b/migration/savevm.c
> > index 6071215..b3f605c 100644
> > --- a/migration/savevm.c
> > +++ b/migration/savevm.c
> > @@ -961,6 +961,11 @@ static int qemu_save_device_state(QEMUFile *f)
> >  
> >      cpu_synchronize_all_states();
> >  
> > +    if (!savevm_state.skip_configuration) {
> > +        qemu_put_byte(f, QEMU_VM_CONFIGURATION);
> > +        vmstate_save_state(f, &vmstate_configuration, &savevm_state, 0);
> > +    }
> > +
> >      QTAILQ_FOREACH(se, &savevm_state.handlers, entry) {
> >          if (se->is_ram) {
> >              continue;
> > -- 
> > Anthony PERARD
> > 

-- 
Anthony PERARD