From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMXq0-0001TL-8S for qemu-devel@nongnu.org; Tue, 04 Aug 2015 04:44:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMXpw-0003EV-6v for qemu-devel@nongnu.org; Tue, 04 Aug 2015 04:44:44 -0400 Received: from mail.ispras.ru ([83.149.199.45]:56262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMXpv-0003E9-WA for qemu-devel@nongnu.org; Tue, 04 Aug 2015 04:44:40 -0400 From: Pavel Dovgalyuk Date: Tue, 04 Aug 2015 11:44:40 +0300 Message-ID: <20150804084440.7280.49230.stgit@PASHA-ISP> In-Reply-To: <20150804084345.7280.75100.stgit@PASHA-ISP> References: <20150804084345.7280.75100.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v16 09/21] i386: interrupt poll processing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, igor.rubinov@gmail.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, hines@cert.org, fred.konrad@greensocs.com This patch updates x86_cpu_exec_interrupt function. It can process two interrupt request at a time (poll and another one). This makes its execution non-deterministic. Determinism is requred for recorded icount execution. Signed-off-by: Pavel Dovgalyuk --- target-i386/seg_helper.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c index 1a3a2e7..1cbe559 100644 --- a/target-i386/seg_helper.c +++ b/target-i386/seg_helper.c @@ -1321,6 +1321,9 @@ bool x86_cpu_exec_interrupt(CPUState *cs, int interrupt_request) if (interrupt_request & CPU_INTERRUPT_POLL) { cs->interrupt_request &= ~CPU_INTERRUPT_POLL; apic_poll_irq(cpu->apic_state); + /* Don't process multiple interrupt requests in a single call. + This is required to make icount-driven execution deterministic. */ + return true; } #endif if (interrupt_request & CPU_INTERRUPT_SIPI) {