From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv2] sdhci: Pass drive parameter to sdhci-pci via qdev property
Date: Tue, 4 Aug 2015 10:00:42 +0100 [thread overview]
Message-ID: <20150804090042.GB6603@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1438533856-27393-1-git-send-email-kevin@koconnor.net>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
On Sun, Aug 02, 2015 at 12:44:16PM -0400, Kevin O'Connor wrote:
> Commit 19109131 disabled the sdhci-pci support because it used
> drive_get_next(). This patch reenables sdhci-pci and changes it to
> pass the drive via a qdev property - for example:
> -device sdhci-pci,drive=drive0 -drive id=drive0,if=sd,file=myimage
>
> Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
> ---
>
> v2:
> - Don't call blk_detach_dev() in sdhci pci code - instead change
> sd_init() to use blk_attach_dev() instead of blk_attach_dev_nofail().
>
> ---
> hw/sd/sd.c | 4 +++-
> hw/sd/sdhci.c | 32 +++++++++++++++++++-------------
> hw/sd/sdhci.h | 2 ++
> 3 files changed, 24 insertions(+), 14 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-08-04 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 16:44 [Qemu-devel] [PATCHv2] sdhci: Pass drive parameter to sdhci-pci via qdev property Kevin O'Connor
2015-08-04 9:00 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804090042.GB6603@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=kevin@koconnor.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).