From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMY5b-0006S0-8W for qemu-devel@nongnu.org; Tue, 04 Aug 2015 05:00:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMY5W-0004a4-FD for qemu-devel@nongnu.org; Tue, 04 Aug 2015 05:00:51 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:35522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMY5V-0004Zo-Mx for qemu-devel@nongnu.org; Tue, 04 Aug 2015 05:00:46 -0400 Received: by wibxm9 with SMTP id xm9so156312602wib.0 for ; Tue, 04 Aug 2015 02:00:45 -0700 (PDT) Date: Tue, 4 Aug 2015 10:00:42 +0100 From: Stefan Hajnoczi Message-ID: <20150804090042.GB6603@stefanha-thinkpad.redhat.com> References: <1438533856-27393-1-git-send-email-kevin@koconnor.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uQr8t48UFsdbeI+V" Content-Disposition: inline In-Reply-To: <1438533856-27393-1-git-send-email-kevin@koconnor.net> Subject: Re: [Qemu-devel] [PATCHv2] sdhci: Pass drive parameter to sdhci-pci via qdev property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: Paolo Bonzini , qemu-devel@nongnu.org, Markus Armbruster --uQr8t48UFsdbeI+V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 02, 2015 at 12:44:16PM -0400, Kevin O'Connor wrote: > Commit 19109131 disabled the sdhci-pci support because it used > drive_get_next(). This patch reenables sdhci-pci and changes it to > pass the drive via a qdev property - for example: > -device sdhci-pci,drive=3Ddrive0 -drive id=3Ddrive0,if=3Dsd,file=3Dmyima= ge >=20 > Signed-off-by: Kevin O'Connor > --- >=20 > v2: > - Don't call blk_detach_dev() in sdhci pci code - instead change > sd_init() to use blk_attach_dev() instead of blk_attach_dev_nofail(). >=20 > --- > hw/sd/sd.c | 4 +++- > hw/sd/sdhci.c | 32 +++++++++++++++++++------------- > hw/sd/sdhci.h | 2 ++ > 3 files changed, 24 insertions(+), 14 deletions(-) Reviewed-by: Stefan Hajnoczi --uQr8t48UFsdbeI+V Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVwH86AAoJEJykq7OBq3PI4HIH/2hcGWxiTdmIBLy8GIUXhunk rgftrWiT4SU0acGZ8sZdrIEbuykbFks6cYEEMx2R1aiM4bsHEMERieRvbQAlHaCA ULTbtbXdX9gcBVZM4PduZIviMvKElPzflBflGgOo37jVE9uaicS+LwcTovmNKlwZ OUsoEF1K5jeOxtI8xF2EYIh1Nm0kvHHp9VDz4/UYZTjhhKyuqu4QsID5g4yr1Ilp UnyM8doui8ikP3eT9+2ekZnS328Zr8DyCADZ2BtyCLLpHTT8NaaCLFOwyrv8kQ9+ vTuOc8xEDTporPw4p07j30YUK1maJzmfWuHlsreYyU87ztyU7dZJwNS7C8os7hY= =SWBH -----END PGP SIGNATURE----- --uQr8t48UFsdbeI+V--