From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMvNX-0006JV-AS for qemu-devel@nongnu.org; Wed, 05 Aug 2015 05:52:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMvNS-0006Pp-PU for qemu-devel@nongnu.org; Wed, 05 Aug 2015 05:52:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMvNS-0006PY-KK for qemu-devel@nongnu.org; Wed, 05 Aug 2015 05:52:50 -0400 Date: Wed, 5 Aug 2015 10:52:46 +0100 From: "Daniel P. Berrange" Message-ID: <20150805095246.GB16246@redhat.com> References: <1438337876-13558-1-git-send-email-berrange@redhat.com> <55BB6EED.2010805@redhat.com> <55BBB755.1060503@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55BBB755.1060503@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Paolo Bonzini , qemu-devel@nongnu.org On Fri, Jul 31, 2015 at 07:58:45PM +0200, Stefan Weil wrote: > Am 31.07.2015 um 14:49 schrieb Paolo Bonzini: > >On 31/07/2015 12:17, Daniel P. Berrange wrote: > >> CC util/osdep.o > >>In file included from include/qemu-common.h:48:0, > >> from util/osdep.c:48: > >>include/sysemu/os-win32.h:77:12: error: redundant redeclaration of 'gmtime_r' [-Werror=redundant-decls] > >> struct tm *gmtime_r(const time_t *timep, struct tm *result); > >> ^ > >>In file included from include/qemu-common.h:35:0, > >> from util/osdep.c:48: > >>/usr/i686-w64-mingw32/sys-root/mingw/include/time.h:272:107: note: previous definition of 'gmtime_r' was here > >>In file included from include/qemu-common.h:48:0, > >> from util/osdep.c:48: > >>include/sysemu/os-win32.h:79:12: error: redundant redeclaration of 'localtime_r' [-Werror=redundant-decls] > >> struct tm *localtime_r(const time_t *timep, struct tm *result); > >> ^ > >>In file included from include/qemu-common.h:35:0, > >> from util/osdep.c:48: > >>/usr/i686-w64-mingw32/sys-root/mingw/include/time.h:269:107: note: previous definition of 'localtime_r' was here > >> > >>This change adds a configure test to see if localtime_r > >>exits, and only enables the QEMU impl if missing. We also > >>re-arrange qemu-common.h try attempt to guarantee that all > >>source files get unistd.h before time.h and thus see the > >>localtime_r/gmtime_r defs. > >These are only with --enable-werror, right? The patch shouldn't be > >necessary for 2.4. > > > >Paolo > > It isn't necessary for 2.4. There are more severe problems which also > seem to be triggered by recent changes in the MinGW-w64 toolchain: > > 64 bit executables crash at longjmp from generated code, > and networking fails because of asynchronous connect calls > which were never implemented correctly in the slirp code. > I'll try to summarize all that I know in a separate mail later. > > I only recently got reports about these problems and think > that it is too late to fix them in 2.4.0. Could you post the info about these problems, or point me to the bug reports. I'm currently trying to get a patchset of mine working on Win32 so need to understand what's broken with Mingw/Win32 currently. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|